linux-kernel - [PATCH v2 6/7] streamline_config.pl: process config options set to "y"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241014141345.5680-7-david.hunter.linux@gmail.com>
Date: Mon, 14 Oct 2024 10:13:36 -0400
From: David Hunter <david.hunter.linux@...il.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: David Hunter <david.hunter.linux@...il.com>,
	linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	shuah@...nel.org,
	javier.carrasco.cruz@...il.com,
	Steven Rostedt <rostedt@...dmis.org>
Subject: [PATCH v2 6/7] streamline_config.pl: process config options set to "y"

An assumption made in this script is that the config options do not need
to be processed because they will simply be in the new config file. This
assumption is incorrect.

Process the config entries set to "y" because those config entries might
have dependencies set to "m". If a config entry is set to "m" and is not
loaded directly into the machine, the script will currently turn off
that config entry; however, if that turned off config entry is a
dependency for a "y" option. that means the config entry set to "y"
will also be turned off later when the conf executive file is called.

Here is a model of the problem (arrows show dependency):

Original config file
Config_1 (m) <-- Config_2 (y)

Config_1 is not loaded in this example, so it is turned off.
After scripts/kconfig/streamline_config.pl, but before scripts/kconfig/conf
Config_1 (n) <-- Config_2 (y)

After  scripts/kconfig/conf
Config_1 (n) <-- Config_2 (n)

It should also be noted that any module in the dependency chain will
also be turned off, even if that module is loaded directly onto the
computer. Here is an example:

Original config file
Config_1 (m) <-- Config_2 (y) <-- Config_3 (m)

Config_3 will be loaded in this example.
After scripts/kconfig/streamline_config.pl, but before scripts/kconfig/conf
Config_1 (n) <-- Config_2 (y) <-- Config_3 (m)

After scripts/kconfig/conf
Config_1 (n) <-- Config_2 (n) <-- Config_3 (n)

Signed-off-by: David Hunter <david.hunter.linux@...il.com>
---
V1 https://lore.kernel.org/all/20240913171205.22126-8-david.hunter.linux@gmail.com/

V2
        - change subject
        - changed part of the code that only processed config options 
          set to "m" so that config options set to "y" are processed. I
          forgot to put this in v1 when making the series patch.
        - removed an unneccessary condition that would have skipped a
          dependency loop.
---
 scripts/kconfig/streamline_config.pl | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index 4149c4b344db..c3b434220c9f 100755
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -473,6 +473,11 @@ foreach my $line (@config_file) {

     if (/(CONFIG_[$valid]*)=(m|y)/) {
 	$orig_configs{$1} = $2;
+	# all configs options set to 'y' need to be processed
+	if ($2 eq "y") {
+            $configs{$1}= $2;
+        }
+
     }
 }

@@ -499,8 +504,8 @@ sub parse_config_depends

 	    $p =~ s/^[^$valid]*[$valid]+//;

-	    # We only need to process if the depend config is a module
-	    if (!defined($orig_configs{$conf}) || $orig_configs{$conf} eq "y") {
+	    # Make sure that this config exists in the current .config file
+	    if (!defined($orig_configs{$conf})) {
 		next;
 	    }

@@ -600,12 +605,6 @@ sub loop_depend {

       forloop:
 	foreach my $config (keys %configs) {
-
-	    # If this config is not a module, we do not need to process it
-	    if (defined($orig_configs{$config}) && $orig_configs{$config} ne "m") {
-		next forloop;
-	    }
-
 	    $config =~ s/^CONFIG_//;
 	    $depconfig = $config;

-- 
2.43.0