linux-kernel - Re: [PATCH v13 05/18] cxl: Move mailbox related bits to the same context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241014154238.000055a3@Huawei.com>
Date: Mon, 14 Oct 2024 15:42:38 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: <shiju.jose@...wei.com>
CC: <linux-edac@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>, <bp@...en8.de>, <tony.luck@...el.com>,
	<rafael@...nel.org>, <lenb@...nel.org>, <mchehab@...nel.org>,
	<dan.j.williams@...el.com>, <dave@...olabs.net>, <dave.jiang@...el.com>,
	<alison.schofield@...el.com>, <vishal.l.verma@...el.com>,
	<ira.weiny@...el.com>, <david@...hat.com>, <Vilas.Sridharan@....com>,
	<leo.duran@....com>, <Yazen.Ghannam@....com>, <rientjes@...gle.com>,
	<jiaqiyan@...gle.com>, <Jon.Grimm@....com>, <dave.hansen@...ux.intel.com>,
	<naoya.horiguchi@....com>, <james.morse@....com>, <jthoughton@...gle.com>,
	<somasundaram.a@....com>, <erdemaktas@...gle.com>, <pgonda@...gle.com>,
	<duenwen@...gle.com>, <gthelen@...gle.com>, <wschwartz@...erecomputing.com>,
	<dferguson@...erecomputing.com>, <wbs@...amperecomputing.com>,
	<nifan.cxl@...il.com>, <tanxiaofei@...wei.com>, <prime.zeng@...ilicon.com>,
	<roberto.sassu@...wei.com>, <kangkang.shen@...urewei.com>,
	<wanghuiqiang@...wei.com>, <linuxarm@...wei.com>
Subject: Re: [PATCH v13 05/18] cxl: Move mailbox related bits to the same
 context

On Wed, 9 Oct 2024 13:41:06 +0100
<shiju.jose@...wei.com> wrote:

> From: Dave Jiang <dave.jiang@...el.com>
> 
> Create a new 'struct cxl_mailbox' and move all mailbox related bits to
> it. This allows isolation of all CXL mailbox data in order to export
> some of the calls to external kernel callers and avoid exporting of CXL
> driver specific bits such has device states. The allocation of
> 'struct cxl_mailbox' is also split out with cxl_mailbox_create() so the
Ira called this out in the v4 posting from Dave.
Change text to say cxl_mailbox_init()

> mailbox can be created independently.
> 
> Reviewed-by: Fan Ni <fan.ni@...sung.com>
> Reviewed-by: Alejandro Lucero <alucerop@....com>
> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
> Link: https://patch.msgid.link/20240724185649.2574627-2-dave.jiang@intel.com

That link is to an old version.
https://lore.kernel.org/linux-cxl/20240905223711.1990186-1-dave.jiang@intel.com/
Is what you have in the cover letter change log so needs to be that here
as well.

I'll review this on Dave's thread rather than here.   Dave, we'll need
a immutable branch for this one once you think it's ready for queuing up.

If we can do that soon that would be good as it's either gating this
series and is a precursor for the type2 stuff.
If we are sure only this stuff will make the coming merge window
(crosses fingers) then we an take it via Borislav's tree
- perhaps we should discuss this on the sync call tomorrow.