linux-kernel - Re: [PATCH] arm64: dts: qcom: x1e80100: Force host dr_mode for usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1cd82c2-5af7-44ec-ac18-996dbc212ce0@linaro.org>
Date: Mon, 14 Oct 2024 17:48:37 +0200
From: neil.armstrong@...aro.org
To: Abel Vesa <abel.vesa@...aro.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Johan Hovold <johan@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Force host dr_mode for usb_2
 controller

On 14/10/2024 16:14, Abel Vesa wrote:
> The usb_2 controller has only a USB 2.0 PHY connected to it. There is no
> USB 3.x PHY fot it. So since dual-role is not an option, explicitly set
> the dr_mode to host to match the hardware.

I don't follow, dual role is perfectly possible with USB2 only, where is the limitation ?

Neil

> 
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 0e6802c1d2d8375987c614ec69c440e2f38d25c6..4da13c8472392d842442193dc740027fa011ee1f 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -4143,6 +4143,7 @@ usb_2_dwc3: usb@...0000 {
>   				iommus = <&apps_smmu 0x14e0 0x0>;
>   				phys = <&usb_2_hsphy>;
>   				phy-names = "usb2-phy";
> +				dr_mode = "host";
>   				maximum-speed = "high-speed";
>   
>   				ports {
> 
> ---
> base-commit: d61a00525464bfc5fe92c6ad713350988e492b88
> change-id: 20241014-x1e80100-usb2-dwc3-set-dr-mode-host-35312d1d25b2
> 
> Best regards,