[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a972dfe9-341b-416c-a245-0834583c6620@amd.com>
Date: Mon, 14 Oct 2024 11:35:27 -0500
From: "Moger, Babu" <babu.moger@....com>
To: "Luck, Tony" <tony.luck@...el.com>
Cc: "corbet@....net" <corbet@....net>, "Yu, Fenghua" <fenghua.yu@...el.com>,
"Chatre, Reinette" <reinette.chatre@...el.com>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
"paulmck@...nel.org" <paulmck@...nel.org>,
"rdunlap@...radead.org" <rdunlap@...radead.org>,
"tj@...nel.org" <tj@...nel.org>, "peterz@...radead.org"
<peterz@...radead.org>, "yanjiewtw@...il.com" <yanjiewtw@...il.com>,
"kim.phillips@....com" <kim.phillips@....com>,
"lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
"seanjc@...gle.com" <seanjc@...gle.com>,
"jmattson@...gle.com" <jmattson@...gle.com>,
"leitao@...ian.org" <leitao@...ian.org>,
"jpoimboe@...nel.org" <jpoimboe@...nel.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
"Joseph, Jithu" <jithu.joseph@...el.com>, "Huang, Kai"
<kai.huang@...el.com>, "kan.liang@...ux.intel.com"
<kan.liang@...ux.intel.com>,
"daniel.sneddon@...ux.intel.com" <daniel.sneddon@...ux.intel.com>,
"pbonzini@...hat.com" <pbonzini@...hat.com>,
"sandipan.das@....com" <sandipan.das@....com>,
"ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
"peternewman@...gle.com" <peternewman@...gle.com>,
"Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Eranian, Stephane" <eranian@...gle.com>,
"james.morse@....com" <james.morse@....com>
Subject: Re: RE: RE: [PATCH v8 19/25] x86/resctrl: Auto assign/unassign
counters when mbm_cntr_assign is enabled
On 12/31/69 18:00, Luck, Tony wrote:
>>>>>> + if (!ret && is_mbm_local_enabled())
>>>>>> + ret = rdtgroup_assign_cntr_event(r, rdtgrp, NULL, QOS_L3_MBM_LOCAL_EVENT_ID);
>>>
>>> Now this call succeeds. The failure of the previous call is forgotten as "ret" is
>>> overwritten with the success code.
>>
>> It will not make this call if the first call fails because of this check.
>>
>> if (!ret && is_mbm_local_enabled())
>> ret = rdtgroup_assign_cntr_event(r, rdtgrp, NULL,
>> QOS_L3_MBM_LOCAL_EVENT_ID);
>>
>> return ret;
>>
>> Here if (!1) evaluates to false.
>>
>> Did I miss something?
>
> You didn't.
>
> I missed the check for ret in the local case.
That is fine,
>
> It is still the case that callers don't care about the return value.
That is correct.
--
Thanks
Babu Moger
Powered by blists - more mailing lists