[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD=FV=UMaAo9x0URaaVNxzx+ztLreAcbiAfLFvDFNcHut5srvg@mail.gmail.com>
Date: Mon, 14 Oct 2024 10:03:34 -0700
From: Doug Anderson <dianders@...omium.org>
To: Cong Yang <yangcong5@...qin.corp-partner.google.com>
Cc: sam@...nborg.org, neil.armstrong@...aro.org, linus.walleij@...aro.org,
airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: himax-hx83102: Adjust power and gamma to
optimize brightness
Hi,
On Fri, Oct 11, 2024 at 7:20 AM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Thu, Oct 10, 2024 at 7:08 PM Cong Yang
> <yangcong5@...qin.corp-partner.google.com> wrote:
> >
> > The current panel brightness is only 360 nit. Adjust the power and gamma to
> > optimize the panel brightness. The brightness after adjustment is 390 nit.
> >
> > Fixes: 3179338750d8 ("drm/panel: Support for IVO t109nw41 MIPI-DSI panel")
When applying your patch, I got a yell about your "Fixes" line. It
turns out you didn't copy the subject of the patch you're fixing
exactly. The above should be:
Fixes: 3179338750d8 ("drm/panel: himax-hx83102: Support for IVO
t109nw41 MIPI-DSI panel")
I'll fix that when applying. Please make sure you get the commit
subject exactly in the future.
> > Signed-off-by: Cong Yang <yangcong5@...qin.corp-partner.google.com>
> > ---
> > drivers/gpu/drm/panel/panel-himax-hx83102.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> No objection on my part. This is just modification of some constants,
> is well described, and is to a panel that you added so I don't think
> it needs a long bake time on the list. I'll plan to apply this on
> Monday unless there are comments or someone beats me to applying.
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
I've applied and pushed to drm-misc-fixes:
[1/1] drm/panel: himax-hx83102: Adjust power and gamma to optimize brightness
commit: fcf38bc321fbc87dfcd829f42e64e541f17599f7
-Doug
Powered by blists - more mailing lists