linux-kernel - Re: [PATCH] drivers/dma: Fix unsigned compared against 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zw1f/OviOSJ9eqJE@vaman>
Date: Mon, 14 Oct 2024 23:46:28 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Advait Dhamorikar <advaitdhamorikar@...il.com>
Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org, anupnewsmail@...il.com
Subject: Re: [PATCH] drivers/dma: Fix unsigned compared against 0

On 05-10-24, 15:04, Advait Dhamorikar wrote:
> An unsigned value can never be negative,
> so this test will always evaluate the same way.
> In ep93xx_dma_alloc_chan_resources: An unsigned dma_cfg.port's
> value is checked against EP93XX_DMA_I2S1 which is 0.

Please use subject line dmaengine: ... git log will tell you the tags to
use

I am fixing it up and applying

> 
> Signed-off-by: Advait Dhamorikar <advaitdhamorikar@...il.com>
> ---
>  drivers/dma/ep93xx_dma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 995427afe077..6d7f6bd12d76 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -929,8 +929,7 @@ static int ep93xx_dma_alloc_chan_resources(struct dma_chan *chan)
>  
>  	/* Sanity check the channel parameters */
>  	if (!edmac->edma->m2m) {
> -		if (edmac->dma_cfg.port < EP93XX_DMA_I2S1 ||
> -		    edmac->dma_cfg.port > EP93XX_DMA_IRDA)
> +		if (edmac->dma_cfg.port > EP93XX_DMA_IRDA)
>  			return -EINVAL;
>  		if (edmac->dma_cfg.dir != ep93xx_dma_chan_direction(chan))
>  			return -EINVAL;
> -- 
> 2.34.1

-- 
~Vinod