linux-kernel - [PATCH] mm/dmapool_test: replace printk with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241014183549.8898-1-quic_pintu@quicinc.com>
Date: Tue, 15 Oct 2024 00:05:49 +0530
From: Pintu Kumar <quic_pintu@...cinc.com>
To: <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
CC: <skhan@...uxfoundation.org>, <pintu.ping@...il.com>,
        Pintu Kumar
	<quic_pintu@...cinc.com>
Subject: [PATCH] mm/dmapool_test: replace printk with pr_info/err

Add SPDX license header and use correct pr_info/err.
These warnings are reported by checkpatch.
This makes the style clean.

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
+#include <linux/device.h>

WARNING: printk() should include KERN_<LEVEL> facility level
+       printk("dmapool test: size:%-4zu align:%-4zu blocks:%-4d time:%llu\n",

[...]

Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>
---
 mm/dmapool_test.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/mm/dmapool_test.c b/mm/dmapool_test.c
index 54b1fd1ccfbb..99269e37ca59 100644
--- a/mm/dmapool_test.c
+++ b/mm/dmapool_test.c
@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
 #include <linux/device.h>
 #include <linux/dma-map-ops.h>
 #include <linux/dma-mapping.h>
@@ -87,7 +89,7 @@ static int dmapool_test_block(const struct dmapool_parms *parms)
 	}
 	end_time = ktime_get();
 
-	printk("dmapool test: size:%-4zu align:%-4zu blocks:%-4d time:%llu\n",
+	pr_info("dmapool test: size:%-4zu align:%-4zu blocks:%-4d time:%llu\n",
 		parms->size, parms->align, blocks,
 		ktime_us_delta(end_time, start_time));
 
@@ -112,7 +114,7 @@ static int dmapool_checks(void)
 
 	ret = device_register(&test_dev);
 	if (ret) {
-		printk("%s: register failed:%d\n", __func__, ret);
+		pr_err("%s: register failed:%d\n", __func__, ret);
 		goto put_device;
 	}
 
@@ -121,7 +123,7 @@ static int dmapool_checks(void)
 	test_dev.dma_mask = &dma_mask;
 	ret = dma_set_mask_and_coherent(&test_dev, DMA_BIT_MASK(64));
 	if (ret) {
-		printk("%s: mask failed:%d\n", __func__, ret);
+		pr_err("%s: mask failed:%d\n", __func__, ret);
 		goto del_device;
 	}
 
-- 
2.17.1