linux-kernel - Re: [PATCH v2 2/2] drm/msm/dsi: fix 32-bit signed integer extension in pclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a76d7a45-fa1a-42d0-a401-1335a7c6d38b@quicinc.com>
Date: Mon, 14 Oct 2024 12:30:21 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Jonathan Marek <jonathan@...ek.ca>, <freedreno@...ts.freedesktop.org>
CC: Rob Clark <robdclark@...il.com>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>,
        Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, "Simona
 Vetter" <simona@...ll.ch>,
        Jessica Zhang <quic_jesszhan@...cinc.com>,
        "Konrad
 Dybcio" <konradybcio@...nel.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        "open
 list:DRM DRIVER for Qualcomm display hardware"
	<linux-arm-msm@...r.kernel.org>,
        "open list:DRM DRIVER for Qualcomm display
 hardware" <dri-devel@...ts.freedesktop.org>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] drm/msm/dsi: fix 32-bit signed integer extension
 in pclk_rate calculation



On 10/6/2024 10:01 PM, Jonathan Marek wrote:
> When (mode->clock * 1000) is larger than (1<<31), int to unsigned long
> conversion will sign extend the int to 64 bits and the pclk_rate value
> will be incorrect.
> 
> Fix this by making the result of the multiplication unsigned.
> 
> Note that above (1<<32) would still be broken and require more changes, but
> its unlikely anyone will need that anytime soon.
> 
> Fixes: c4d8cfe516dc ("drm/msm/dsi: add implementation for helper functions")
> Signed-off-by: Jonathan Marek <jonathan@...ek.ca>
> ---
>   drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>