[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241014-roamer-cinnamon-1e100b485052@spud>
Date: Mon, 14 Oct 2024 21:31:09 +0100
From: Conor Dooley <conor@...nel.org>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>,
Conor Dooley <conor+dt@...nel.org>,
Jack Zhu <jack.zhu@...rfivetech.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
E Shattow <lucent@...il.com>
Subject: Re: 回复: [v3] riscv: dts:
starfive: jh7110: Add camera subsystem nodes
On Mon, Oct 14, 2024 at 10:27:41PM +0200, Aurelien Jarno wrote:
> Hi,
>
> On 2024-10-14 01:08, Changhuang Liang wrote:
> > Hi, Aurelien
> >
> > >
> > > Hi,
> > >
> > > On 2024-02-18 19:27, Changhuang Liang wrote:
> > > > Add camera subsystem nodes for the StarFive JH7110 SoC. They contain
> > > > the dphy-rx, csi2rx, camss nodes.
> > > >
> > > > Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> > > > ---
> > > > .../jh7110-starfive-visionfive-2.dtsi | 49 ++++++++++++++
> > > > arch/riscv/boot/dts/starfive/jh7110.dtsi | 67
> > > +++++++++++++++++++
> > > > 2 files changed, 116 insertions(+)
> > >
> > > We have been asked to enable CONFIG_VIDEO_STARFIVE_CAMSS in the
> > > Debian kernel, which from my understanding and given the device tree shown
> > > below also requires enabling CONFIG_VIDEO_CADENCE_CSI2RX. That said
> > > doing so triggers the following error in dmesg:
> > >
> > > [ 25.143282] cdns-csi2rx 19800000.csi: probe with driver cdns-csi2rx
> > > failed with error -22
> > >
> > > From a quick look it seems there is something in the port@0 csi2rx entry. Do
> > > you happen to know what is wrong?
> > >
> >
> > You need to add your sensor node. You can refer to this patch:
> > https://patchwork.kernel.org/project/linux-riscv/patch/20240119100639.84029-3-changhuang.liang@starfivetech.com/
> >
> > We suggest that using the imx219
>
> Thanks for your answer. I do not have any sensor attached, the goal is
> to build a generic kernel, and people can use overlays or patch their
> device tree to add support for additional devices.
>
> In that regard, I have the impression that csi2rx device (and maybe the
> camss device?) should not be marked as enabled in the default device
> tree. I think they could be enabled by users as part of the change need
> to add the sensor node.
Yeah, that's probably what should've been done when the imx219 node was
removed. Feel free to send a patch with a Fixes: tag for that removal
and a cc: stable on it - otherwise I'll send one out tomorrow or w/e.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists