linux-kernel - Re: [PATCH] fbdev: Constify struct sbus_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa4bf800-1bd9-4af4-8403-aa9ff6d30ae1@gmx.de>
Date: Mon, 14 Oct 2024 22:32:13 +0200
From: Helge Deller <deller@....de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] fbdev: Constify struct sbus_mmap_map

On 10/13/24 13:48, Christophe JAILLET wrote:
> 'struct sbus_mmap_map' are not modified in these drivers.
>
> Constifying this structure moves some data to a read-only section, so
> increases overall security.
>
> Update sbusfb_mmap_helper() accordingly.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>     text	   data	    bss	    dec	    hex	filename
>     2452	    536	     16	   3004	    bbc	drivers/video/fbdev/bw2.o
>
> After:
> =====
>     text	   data	    bss	    dec	    hex	filename
>     2500	    483	     16	   2999	    bb7	drivers/video/fbdev/bw2.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only with a cross compiler for sparc.
> ---
>   drivers/video/fbdev/bw2.c     | 2 +-
>   drivers/video/fbdev/cg14.c    | 2 +-
>   drivers/video/fbdev/cg3.c     | 2 +-
>   drivers/video/fbdev/cg6.c     | 2 +-
>   drivers/video/fbdev/ffb.c     | 2 +-
>   drivers/video/fbdev/leo.c     | 2 +-
>   drivers/video/fbdev/p9100.c   | 2 +-
>   drivers/video/fbdev/sbuslib.c | 2 +-
>   drivers/video/fbdev/sbuslib.h | 2 +-
>   drivers/video/fbdev/tcx.c     | 2 +-
>   10 files changed, 10 insertions(+), 10 deletions(-)

applied.

Thanks!
Helge