[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241014214236.99604-1-kuniyu@amazon.com>
Date: Mon, 14 Oct 2024 14:42:36 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <ignat@...udflare.com>
CC: <alex.aring@...il.com>, <alibuda@...ux.alibaba.com>,
<davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
<johan.hedberg@...il.com>, <kernel-team@...udflare.com>, <kuba@...nel.org>,
<kuniyu@...zon.com>, <linux-bluetooth@...r.kernel.org>,
<linux-can@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-wpan@...r.kernel.org>, <luiz.dentz@...il.com>, <marcel@...tmann.org>,
<miquel.raynal@...tlin.com>, <mkl@...gutronix.de>, <netdev@...r.kernel.org>,
<pabeni@...hat.com>, <socketcan@...tkopp.net>, <stefan@...enfreihafen.org>,
<willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next v3 9/9] Revert "net: do not leave a dangling sk pointer, when socket creation fails"
From: Ignat Korchagin <ignat@...udflare.com>
Date: Mon, 14 Oct 2024 16:38:08 +0100
> This reverts commit 6cd4a78d962bebbaf8beb7d2ead3f34120e3f7b2.
>
> inet/inet6->create() implementations have been fixed to explicitly NULL the
> allocated sk object on error.
>
> A warning was put in place to make sure any future changes will not leave
> a dangling pointer in pf->create() implementations.
>
> So this code is now redundant.
>
> Suggested-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> Signed-off-by: Ignat Korchagin <ignat@...udflare.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>
Powered by blists - more mailing lists