linux-kernel - Re: [PATCH] remoteproc: elf_loader: redundant check remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jerzlrs3vwtf6wb4bhgprmsdmfm7usv7qec34hfzj7q6oxhqwd@7isqdegmqwei>
Date: Mon, 14 Oct 2024 18:36:53 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: anish kumar <yesanishhere@...il.com>
Cc: mathieu.poirier@...aro.org, linux-remoteproc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remoteproc: elf_loader: redundant check remove

On Sun, Oct 13, 2024 at 10:48:20PM GMT, anish kumar wrote:
> offset will always be positive number and adding
> and comparing to the same variable 'size' will
> always result in check being false always.
> Remove this superfluous check.
> 

What if offset + size overflows?

Regards,
Bjorn

> Signed-off-by: anish kumar <yesanishhere@...il.com>
> ---
>  drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c
> index 94177e416047..c6d893e9c15e 100644
> --- a/drivers/remoteproc/remoteproc_elf_loader.c
> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
> @@ -278,7 +278,7 @@ find_table(struct device *dev, const struct firmware *fw)
>  		table = (struct resource_table *)(elf_data + offset);
>  
>  		/* make sure we have the entire table */
> -		if (offset + size > fw_size || offset + size < size) {
> +		if (offset + size > fw_size) {
>  			dev_err(dev, "resource table truncated\n");
>  			return NULL;
>  		}
> -- 
> 2.39.3 (Apple Git-146)
>