linux-kernel - Re: [PATCH] selftests/intel_pstate: fix operand expected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0997dba1-2289-4291-a06a-f9041a95c16c@linuxfoundation.org>
Date: Mon, 14 Oct 2024 17:41:28 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Alessandro Zanni <alessandro.zanni87@...il.com>, shuah@...nel.org
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 anupnewsmail@...il.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/intel_pstate: fix operand expected

On 10/14/24 08:09, Alessandro Zanni wrote:
> This fix solves these errors, when calling kselftest with
> targets "intel_pstate":

What is "calling" kselftest? Please include the command you
ran in the change log.

Also, say "Fix" instead of "This fix"

Running "command" results in the following errors:

<errors>

Fix them

> 
> - ./run.sh: line 90: / 1000: syntax error: operand expected
> (error token is "/ 1000")
> - ./run.sh: line 92: / 1000: syntax error: operand expected
> (error token is "/ 1000")
> 
> To error was found by running tests manually with the command:

"To" -> These?

> make kselftest TARGETS=intel_pstate

Why not just move this up:

I don't see any errors when I run the above command on Linux 6.12-rc3
What's you environment like?

> 
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@...il.com>
> ---
>   tools/testing/selftests/intel_pstate/run.sh | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> index e7008f614ad7..39130a359535 100755
> --- a/tools/testing/selftests/intel_pstate/run.sh
> +++ b/tools/testing/selftests/intel_pstate/run.sh
> @@ -87,9 +87,11 @@ mkt_freq=${_mkt_freq}0
>   
>   # Get the ranges from cpupower
>   _min_freq=$(cpupower frequency-info -l | tail -1 | awk ' { print $1 } ')
> -min_freq=$(($_min_freq / 1000))
> +min_freq=$((_min_freq / 1000))
> +echo "min_freq:"
> +echo $min_freq
>   _max_freq=$(cpupower frequency-info -l | tail -1 | awk ' { print $2 } ')
> -max_freq=$(($_max_freq / 1000))
> +max_freq=$((_max_freq / 1000))
>   
>   
>   [ $EVALUATE_ONLY -eq 0 ] && for freq in `seq $max_freq -100 $min_freq`

thanks,
-- Shuah