linux-kernel - Re: [PATCH] elevator: Remove argument from elevator_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zwyym8cvSYg2Qh-R@infradead.org>
Date: Sun, 13 Oct 2024 22:56:43 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Breno Leitao <leitao@...ian.org>
Cc: hch@...radead.org, Jens Axboe <axboe@...nel.dk>,
	Bart Van Assche <bvanassche@....org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Damien Le Moal <dlemoal@...nel.org>, Hannes Reinecke <hare@...e.de>,
	kernel-team@...a.com,
	"open list:BLOCK LAYER" <linux-block@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] elevator: Remove argument from elevator_find_get

On Fri, Oct 11, 2024 at 08:56:15AM -0700, Breno Leitao wrote:
> Commit e4eb37cc0f3ed ("block: Remove elevator required features")
> removed the usage of `struct request_queue` from elevator_find_get(),
> but didn't removed the argument.
> 
> Remove the "struct request_queue *q" argument from elevator_find_get()
> given it is useless.
> 
> Fixes: e4eb37cc0f3e ("block: Remove elevator required features")
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>