[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <13616137.uLZWGnKmhe@diego>
Date: Mon, 14 Oct 2024 08:50:59 +0200
From: Heiko Stübner <heiko@...ech.de>
To: vkoul@...nel.org, kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, Frank Wang <frawang.cn@...il.com>
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org, william.wu@...k-chips.com,
tim.chen@...k-chips.com, yubing.zhang@...k-chips.com,
Frank Wang <frank.wang@...k-chips.com>
Subject: Re: [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data
Am Montag, 14. Oktober 2024, 04:03:42 CEST schrieb Frank Wang:
> From: Frank Wang <frank.wang@...k-chips.com>
>
> This adds RK3576 device match data support.
>
> Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
Nice, that the rk3576 support fits in so easily :-)
Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> ---
> drivers/phy/rockchip/phy-rockchip-usbdp.c | 41 +++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> index 2c51e5c62d3e..5b1e8a3806ed 100644
> --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c
> +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> @@ -1538,6 +1538,43 @@ static const char * const rk_udphy_rst_list[] = {
> "init", "cmn", "lane", "pcs_apb", "pma_apb"
> };
>
> +static const struct rk_udphy_cfg rk3576_udphy_cfgs = {
> + .num_phys = 1,
> + .phy_ids = { 0x2b010000 },
> + .num_rsts = ARRAY_SIZE(rk_udphy_rst_list),
> + .rst_list = rk_udphy_rst_list,
> + .grfcfg = {
> + /* u2phy-grf */
> + .bvalid_phy_con = RK_UDPHY_GEN_GRF_REG(0x0010, 1, 0, 0x2, 0x3),
> + .bvalid_grf_con = RK_UDPHY_GEN_GRF_REG(0x0000, 15, 14, 0x1, 0x3),
> +
> + /* usb-grf */
> + .usb3otg0_cfg = RK_UDPHY_GEN_GRF_REG(0x0030, 15, 0, 0x1100, 0x0188),
> +
> + /* usbdpphy-grf */
> + .low_pwrn = RK_UDPHY_GEN_GRF_REG(0x0004, 13, 13, 0, 1),
> + .rx_lfps = RK_UDPHY_GEN_GRF_REG(0x0004, 14, 14, 0, 1),
> + },
> + .vogrfcfg = {
> + {
> + .hpd_trigger = RK_UDPHY_GEN_GRF_REG(0x0000, 11, 10, 1, 3),
> + .dp_lane_reg = 0x0000,
> + },
> + },
> + .dp_tx_ctrl_cfg = {
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_hbr2,
> + rk3588_dp_tx_drv_ctrl_hbr3,
> + },
> + .dp_tx_ctrl_cfg_typec = {
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_hbr2,
> + rk3588_dp_tx_drv_ctrl_hbr3,
> + },
> +};
> +
> static const struct rk_udphy_cfg rk3588_udphy_cfgs = {
> .num_phys = 2,
> .phy_ids = {
> @@ -1584,6 +1621,10 @@ static const struct rk_udphy_cfg rk3588_udphy_cfgs = {
> };
>
> static const struct of_device_id rk_udphy_dt_match[] = {
> + {
> + .compatible = "rockchip,rk3576-usbdp-phy",
> + .data = &rk3576_udphy_cfgs
> + },
> {
> .compatible = "rockchip,rk3588-usbdp-phy",
> .data = &rk3588_udphy_cfgs
>
Powered by blists - more mailing lists