[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8734kznoiw.fsf@nvdebian.thelocal>
Date: Mon, 14 Oct 2024 18:14:30 +1100
From: Alistair Popple <apopple@...dia.com>
To: Alexander Gordeev <agordeev@...ux.ibm.com>
Cc: dan.j.williams@...el.com, linux-mm@...ck.org, vishal.l.verma@...el.com,
dave.jiang@...el.com, logang@...tatee.com, bhelgaas@...gle.com,
jack@...e.cz, jgg@...pe.ca, catalin.marinas@....com, will@...nel.org,
mpe@...erman.id.au, npiggin@...il.com, dave.hansen@...ux.intel.com,
ira.weiny@...el.com, willy@...radead.org, djwong@...nel.org,
tytso@....edu, linmiaohe@...wei.com, david@...hat.com, peterx@...hat.com,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org,
nvdimm@...ts.linux.dev, linux-cxl@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
linux-xfs@...r.kernel.org, jhubbard@...dia.com, hch@....de,
david@...morbit.com
Subject: Re: [PATCH 11/12] mm: Remove pXX_devmap callers
Alexander Gordeev <agordeev@...ux.ibm.com> writes:
> On Tue, Sep 10, 2024 at 02:14:36PM +1000, Alistair Popple wrote:
>
> Hi Alistair,
>
>> diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book3s64/pgtable.c
>> index 5a4a753..4537a29 100644
>> --- a/arch/powerpc/mm/book3s64/pgtable.c
>> +++ b/arch/powerpc/mm/book3s64/pgtable.c
>> @@ -193,7 +192,7 @@ pmd_t pmdp_huge_get_and_clear_full(struct vm_area_struct *vma,
>> pmd_t pmd;
>> VM_BUG_ON(addr & ~HPAGE_PMD_MASK);
>> VM_BUG_ON((pmd_present(*pmdp) && !pmd_trans_huge(*pmdp) &&
>> - !pmd_devmap(*pmdp)) || !pmd_present(*pmdp));
>> + || !pmd_present(*pmdp));
>
> That looks broken.
Thanks! Clearly I better go reinstall that PPC cross-compiler...
>> pmd = pmdp_huge_get_and_clear(vma->vm_mm, addr, pmdp);
>> /*
>> * if it not a fullmm flush, then we can possibly end up converting
>
> Thanks!
Powered by blists - more mailing lists