linux-kernel - Re: [PATCH V3 2/2] dt-bindings: arm: rockchip: Add Orange Pi 5b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3khrvo5fhft6kagr33oamfo744iqdriaccd75m5le7lsk4n27k@6awyomnakwv3>
Date: Mon, 14 Oct 2024 09:24:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Cenk Uluisik <cenk.uluisik@...glemail.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Chris Morgan <macromorgan@...mail.com>, 
	Dragan Simic <dsimic@...jaro.org>, Jonas Karlman <jonas@...boo.se>, Tim Lunn <tim@...thertop.org>, 
	Andy Yan <andyshrk@....com>, Jagan Teki <jagan@...eble.ai>, 
	Michael Riesch <michael.riesch@...fvision.net>, Jimmy Hon <honyuenkwun@...il.com>, Jing Luo <jing@...g.rocks>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 2/2] dt-bindings: arm: rockchip: Add Orange Pi 5b

On Sun, Oct 13, 2024 at 11:32:37PM +0200, Cenk Uluisik wrote:
> This commit adds the Xunlong Orange Pi 5b entry to the device tree
> bindings inside the Documentation folder. I know you said I
> should extend the Orange Pi 5 one with an enum, but I made a whole new
> entry, because looking at all the other entries, they also create new
> entries in a case "like this". I hope this is okay, or maybe I misunderstand something.
> Thank you in advance.

That's not suitable for commit msg. Explain the hardware.

And no, use an enum.


> 
> Signed-off-by: Cenk Uluisik <cenk.uluisik@...glemail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 687823e58c22..130f6ccc1658 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1053,6 +1053,11 @@ properties:
>          items:
>            - const: xunlong,orangepi-5
>            - const: rockchip,rk3588s
> +      

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

Best regards,
Krzysztof