linux-kernel - Re: [PATCH 2/2] media: dt-bindings: Use additionalProperties: false for endpoint: properties:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ecxjoa7aije46cxmkyfd6ihxnqw4wleqkioddomxbwlu7qtrc@4dkfitppeksu>
Date: Mon, 14 Oct 2024 09:45:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Martin Kepplinger <martink@...teo.de>, 
	Paul Kocialkowski <paul.kocialkowski@...tlin.com>, "Paul J. Murphy" <paul.j.murphy@...el.com>, 
	Daniele Alessandrelli <daniele.alessandrelli@...el.com>, Tommaso Merciai <tomm.merciai@...il.com>, 
	Martin Hecht <martin.hecht@...et.eu>, Zhi Mao <zhi.mao@...iatek.com>, 
	Alain Volmat <alain.volmat@...s.st.com>, Mikhail Rudenko <mike.rudenko@...il.com>, 
	Ricardo Ribalda <ribalda@...nel.org>, Kieran Bingham <kieran.bingham@...asonboard.com>, 
	Umang Jain <umang.jain@...asonboard.com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, Dongchun Zhu <dongchun.zhu@...iatek.com>, 
	Quentin Schulz <quentin.schulz@...obroma-systems.com>, Todor Tomov <todor.too@...il.com>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] media: dt-bindings: Use additionalProperties: false
 for endpoint: properties:

On Sat, Oct 12, 2024 at 04:02:51PM +0100, Bryan O'Donoghue wrote:
> Some of our sensor schemas use unevaluatedProperities: false for endpoint:
> properties: while other schemas use additionalProperties: false.
> 
> The effect of using unevaluatedProperities: false in this instance is that
> any property in media/video-interfaces.yaml can be considered in a dts for
> an endpoint.

... which is what we want and what is expected.

You change the code from expected to less expected variant, so please
clearly document why.

> 
> Converting to additionalProperties: false and running DT checkers show that
> such a liberal policy is unnecessary.
> 
> We should have a consistent way of defining these properties if for no
> other reason than aid other developers in the preferred way of writing
> these schemas for media/i2c in the future.

There is consistent way - common schema defines them.

I do not understand the reasoning behind this change at all. I don't
think DT maintainers ever suggested it (in fact, rather opposite:
suggested using unevaluatedProps) and I think is not a consensus of any
talks.

Best regards,
Krzysztof