linux-kernel - Re: [PATCH v6 6/8] dt-bindings: pinctrl: mediatek: Add bindings for MT6735 pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66ad5cd6-cac2-400a-95c2-f72d68b2a706@collabora.com>
Date: Mon, 14 Oct 2024 09:59:05 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Yassine Oudjana <yassine.oudjana@...il.com>,
 Sean Wang <sean.wang@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>
Cc: Yassine Oudjana <y.oudjana@...tonmail.com>,
 Andy Teng <andy.teng@...iatek.com>, linux-mediatek@...ts.infradead.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 6/8] dt-bindings: pinctrl: mediatek: Add bindings for
 MT6735 pin controller

Il 11/10/24 14:03, Yassine Oudjana ha scritto:
> From: Yassine Oudjana <y.oudjana@...tonmail.com>
> 
> Add DT bindings for the MT6735 pin controller, which consist of macros
> to be used as values for the pinmux property. Each macro corresponds
> to a unique possible pin-function combination.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> ---
>   MAINTAINERS                                   |    6 +
>   .../pinctrl/mediatek,mt6735-pinctrl.h         | 1148 +++++++++++++++++
>   2 files changed, 1154 insertions(+)
>   create mode 100644 include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e336dab6fdd1a..f95ae886f9fd8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18311,6 +18311,12 @@ F:	drivers/pinctrl/mediatek/pinctrl-rt2880.c
>   F:	drivers/pinctrl/mediatek/pinctrl-rt305x.c
>   F:	drivers/pinctrl/mediatek/pinctrl-rt3883.c
>   
> +PIN CONTROLLER - MEDIATEK MT6735
> +M:	Yassine Oudjana <y.oudjana@...tonmail.com>
> +L:	linux-mediatek@...ts.infradead.org (moderated for non-subscribers)
> +S:	Maintained
> +F:	include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h
> +
>   PIN CONTROLLER - MICROCHIP AT91
>   M:	Ludovic Desroches <ludovic.desroches@...rochip.com>
>   L:	linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
> diff --git a/include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h b/include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h
> new file mode 100644
> index 0000000000000..1134caf9022c5
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h

They're all called "pinfunc", even the newest mt8188 one, so please:

mediatek,mt6735-pinfunc.h

just for consistency and nothing else

> @@ -0,0 +1,1148 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (C) 2022 Yassine Oudjana <y.oudjana@...tonmail.com>
> + */
> +
> +#ifndef __DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H__
> +#define __DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H__

#ifndef _DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H
#define _DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H

#endif /* _DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H */

Cheers,
Angelo