linux-kernel - Re: [PATCH v7 4/5] gpio: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e612ef6af75929fa874817e6e8b4b69473af8051.camel@redhat.com>
Date: Mon, 14 Oct 2024 10:27:32 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Jens Axboe <axboe@...nel.dk>, Wu Hao <hao.wu@...el.com>, Tom Rix
 <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>, Xu Yilun
 <yilun.xu@...el.com>,  Andy Shevchenko <andy@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Richard
 Cochran <richardcochran@...il.com>, Damien Le Moal <dlemoal@...nel.org>,
 Hannes Reinecke <hare@...e.de>, Al Viro <viro@...iv.linux.org.uk>,  Keith
 Busch <kbusch@...nel.org>, Li Zetao <lizetao1@...wei.com>,
 linux-block@...r.kernel.org,  linux-kernel@...r.kernel.org,
 linux-fpga@...r.kernel.org,  linux-gpio@...r.kernel.org,
 netdev@...r.kernel.org, linux-pci@...r.kernel.org,  Bartosz Golaszewski
 <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v7 4/5] gpio: Replace deprecated PCI functions

On Mon, 2024-10-14 at 10:15 +0200, Bartosz Golaszewski wrote:
> On Mon, Oct 14, 2024 at 10:08 AM Philipp Stanner
> <pstanner@...hat.com> wrote:
> > 
> > On Mon, 2024-10-14 at 09:59 +0200, Bartosz Golaszewski wrote:
> > > On Mon, Oct 14, 2024 at 9:53 AM Philipp Stanner
> > > <pstanner@...hat.com>
> > > wrote:
> > > > 
> > > > pcim_iomap_regions() and pcim_iomap_table() have been
> > > > deprecated by
> > > > the
> > > > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> > > > pcim_iomap_table(), pcim_iomap_regions_request_all()").
> > > > 
> > > > Replace those functions with calls to pcim_iomap_region().
> > > > 
> > > > Signed-off-by: Philipp Stanner <pstanner@...hat.com>
> > > > Reviewed-by: Andy Shevchenko <andy@...nel.org>
> > > > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > > > ---
> > > 
> > > This is part of a larger series so I acked it previously but at
> > > second
> > > glance it doesn't look like it depends on anything that comes
> > > before?
> > > Should it have been sent separately to the GPIO tree? Should I
> > > pick
> > > it
> > > up independently?
> > 
> > Thx for the offer, but it depends on pcim_iounmap_region(), which
> > only
> > becomes a public symbol through patch No.1 of this series :)
> > 
> 
> Then a hint: to make it more obvious to maintainers, I'd change the
> commit title for patch 1 to say explicitly it makes this function
> public. In fact: I'd split it and the deprecation into two separate
> patches.

Yeah, good idea. The maintainer could squash then if two atomic patches
are deemed undesirable.

Noted.
Thank you!
P.

> 
> Bart
>