[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<TYZPR06MB5203FD3066CCAD07405CAAACB2442@TYZPR06MB5203.apcprd06.prod.outlook.com>
Date: Mon, 14 Oct 2024 02:07:58 +0000
From: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
To: Rob Herring <robh@...nel.org>
CC: "patrick@...cx.xyz" <patrick@...cx.xyz>, "wim@...ux-watchdog.org"
<wim@...ux-watchdog.org>, "linux@...ck-us.net" <linux@...ck-us.net>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, "joel@....id.au" <joel@....id.au>,
"andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "Peter.Yin@...ntatw.com"
<Peter.Yin@...ntatw.com>, "Patrick_NC_Lin@...ynn.com"
<Patrick_NC_Lin@...ynn.com>, "Bonnie_Lo@...ynn.com" <Bonnie_Lo@...ynn.com>,
"DELPHINE_CHIU@...ynn.com" <DELPHINE_CHIU@...ynn.com>, BMC-SW
<BMC-SW@...eedtech.com>
Subject: RE: [PATCH 1/4] dt-bindings: watchdog: aspeed: Add property for WDT
SW reset
Hi Rob,
Thanks for the review.
> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Tuesday, October 8, 2024 2:00 AM
> Subject: Re: [PATCH 1/4] dt-bindings: watchdog: aspeed: Add property for WDT
> SW reset
>
> On Mon, Oct 07, 2024 at 02:34:05PM +0800, Chin-Ting Kuo wrote:
> > Add "aspeed,restart-sw" property to distinguish normal WDT reset from
> > system restart triggered by SW consciously.
> >
> > Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
> > ---
> > .../bindings/watchdog/aspeed,ast2400-wdt.yaml | 11
> +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> > b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> > index be78a9865584..6cc3604c295a 100644
> > ---
> > a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.ya
> > +++ ml
> > @@ -95,6 +95,17 @@ properties:
> > array with the first word defined using the AST2600_WDT_RESET1_*
> macros,
> > and the second word defined using the AST2600_WDT_RESET2_*
> macros.
> >
> > + aspeed,restart-sw:
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + description: >
> > + Normally, ASPEED WDT reset may occur when system hangs or
> reboot
> > + triggered by SW consciously. However, system doesn't know whether
> the
> > + restart is triggered by SW consciously since the reset event flag is
> > + the same as normal WDT timeout reset. With this property, SW can
> > + restart the system immediately and directly without wait for WDT
> > + timeout occurs. The reset event flag is also different from the
> normal
> > + WDT reset. This property is only supported since AST2600 platform.
>
> Why can't this be implicit based on the ast2600 compatible string?
>
Yes, this property will be implicit based on the ast2600 compatible string
in the next patch series.
> Rob
Chin-Ting
Powered by blists - more mailing lists