lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZwziGzex9RmVlcNa@J2N7QTR9R3>
Date: Mon, 14 Oct 2024 10:19:23 +0100
From: Mark Rutland <mark.rutland@....com>
To: Ba Jing <bajing@...s.chinamobile.com>
Cc: will@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH] perf: arm-ccn: remove unused macros

On Sat, Oct 12, 2024 at 05:16:29PM +0800, Ba Jing wrote:
> By reading the code, I found these marcos are never
> referenced in the code. Just remove them.
> 
> Signed-off-by: Ba Jing <bajing@...s.chinamobile.com>

These are control bit values, so I don't see a strong reason to delete
them unless we're certain we're not going to use them in future.

Anyhow, Robin Murphy wrote this driver, so its up to him. Please Cc him
for any changes to this driver in future.

Mark.

> ---
>  drivers/perf/arm-ccn.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
> index 5c66b9278862..ea878b025d32 100644
> --- a/drivers/perf/arm-ccn.c
> +++ b/drivers/perf/arm-ccn.c
> @@ -28,12 +28,7 @@
>  
>  #define CCN_MN_ERRINT_STATUS		0x0008
>  #define CCN_MN_ERRINT_STATUS__INTREQ__DESSERT		0x11
> -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__ENABLE	0x02
> -#define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLED	0x20
>  #define CCN_MN_ERRINT_STATUS__ALL_ERRORS__DISABLE	0x22
> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_ENABLE	0x04
> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLED	0x40
> -#define CCN_MN_ERRINT_STATUS__CORRECTED_ERRORS_DISABLE	0x44
>  #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__ENABLE	0x08
>  #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLED	0x80
>  #define CCN_MN_ERRINT_STATUS__PMU_EVENTS__DISABLE	0x88
> -- 
> 2.33.0
> 
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ