linux-kernel - Re: [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172889900570.877857.1005868402461236136@ping.linuxembedded.co.uk>
Date: Mon, 14 Oct 2024 10:43:25 +0100
From: Kieran Bingham <kieran.bingham@...asonboard.com>
To: Abhishek Tamboli <abhishektamboli9@...il.com>, gregkh@...uxfoundation.org
Cc: Frank.Li@....com, m.grzeschik@...gutronix.de, dan.scally@...asonboard.com, andrzej.p@...labora.com, quic_jjohnson@...cinc.com, shuzhenwang@...gle.com, arakesh@...gle.com, skhan@...uxfoundation.org, rbmarliere@...il.com, linux-kernel-mentees@...ts.linuxfoundation.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro

Quoting Abhishek Tamboli (2024-10-13 15:25:11)
> Remove the extra semicolon after the
> do {} while (0) in UVC_COPY_DESCRIPTOR macro.
> 
> Fix the following checkpatch.pl warning
> 
> WARNING: do {} while (0) macros should not be semicolon terminated
> +#define UVC_COPY_DESCRIPTOR(mem, dst, desc) \
> +       do { \
> +               memcpy(mem, desc, (desc)->bLength); \
> +               *(dst)++ = mem; \
> +               mem += (desc)->bLength; \
> +       } while (0);
> 
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@...il.com>

Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>

> ---
>  drivers/usb/gadget/function/f_uvc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c
> index 40187b7112e7..edf0355d712c 100644
> --- a/drivers/usb/gadget/function/f_uvc.c
> +++ b/drivers/usb/gadget/function/f_uvc.c
> @@ -465,7 +465,7 @@ uvc_register_video(struct uvc_device *uvc)
>                 memcpy(mem, desc, (desc)->bLength); \
>                 *(dst)++ = mem; \
>                 mem += (desc)->bLength; \
> -       } while (0);
> +       } while (0)
> 
>  #define UVC_COPY_DESCRIPTORS(mem, dst, src) \
>         do { \
> --
> 2.34.1
>