linux-kernel - [PATCH v2] scripts/decode_stacktrace.sh: remove trailing space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241014100213.1873611-1-leitao@debian.org>
Date: Mon, 14 Oct 2024 03:02:10 -0700
From: Breno Leitao <leitao@...ian.org>
To: akpm@...ux-foundation.org
Cc: Elliot Berman <quic_eberman@...cinc.com>,
	Carlos Llamas <cmllamas@...gle.com>,
	Stephen Boyd <swboyd@...omium.org>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Xiong Nandi <xndchn@...il.com>,
	Bjorn Andersson <quic_bjorande@...cinc.com>,
	linux-kernel@...r.kernel.org (open list)
Subject: [PATCH v2] scripts/decode_stacktrace.sh: remove trailing space

decode_stacktrace.sh adds a trailing space at the end of the decoded
stack if the module is not set (in most of the lines), which makes the
some lines of the stack having trailing space and some others not.

Do not add an extra space at the end of the line if module is not set,
adding consistency in output formatting.

Signed-off-by: Breno Leitao <leitao@...ian.org>
Reviewed-by: Elliot Berman <quic_eberman@...cinc.com>
Reviewed-by: Carlos Llamas <cmllamas@...gle.com>
Reviewed-by: Stephen Boyd <swboyd@...omium.org>
---
Changelog:
v2:
 * Add double squared brackets instead of a single one (Carlos)

 scripts/decode_stacktrace.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
index 826836d264c6..46fa18b80fc1 100755
--- a/scripts/decode_stacktrace.sh
+++ b/scripts/decode_stacktrace.sh
@@ -311,7 +311,12 @@ handle_line() {
 	parse_symbol # modifies $symbol
 
 	# Add up the line number to the symbol
-	echo "${words[@]}" "$symbol $module"
+	if [[ -z ${module} ]]
+	then
+		echo "${words[@]}" "$symbol"
+	else
+		echo "${words[@]}" "$symbol $module"
+	fi
 }
 
 while read line; do
-- 
2.43.5