linux-kernel - Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0240feca-541d-4aa9-abde-c0b0b0b477e5@linaro.org>
Date: Mon, 14 Oct 2024 11:08:43 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>, Shawn Guo
 <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Martin Kepplinger <martink@...teo.de>,
 Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
 "Paul J. Murphy" <paul.j.murphy@...el.com>,
 Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
 Tommaso Merciai <tomm.merciai@...il.com>,
 Martin Hecht <martin.hecht@...et.eu>, Zhi Mao <zhi.mao@...iatek.com>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Mikhail Rudenko <mike.rudenko@...il.com>,
 Ricardo Ribalda <ribalda@...nel.org>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Dongchun Zhu <dongchun.zhu@...iatek.com>,
 Quentin Schulz <quentin.schulz@...obroma-systems.com>,
 Todor Tomov <todor.too@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from
 various schema

On 14/10/2024 09:44, Krzysztof Kozlowski wrote:
> On 14/10/2024 10:29, Bryan O'Donoghue wrote:
>> On 14/10/2024 08:43, Krzysztof Kozlowski wrote:
>>>> -  - assigned-clocks
>>>> -  - assigned-clock-rates
>>> That's not extraneous, but has a meaning that without assigned-clocks
>>> this device or driver will not operate.
>>>
>>> File should rather stay as is.
>>
>> Hmm, I've obviously missed a trick here.
>>
>> I'll check it out.
> 
> My response was probably not complete: this still might be extraneous,
> because maybe the driver/device do not care. But in general requiring
> assigned-clocks could have a meaning.

No I see what you mean

Even though assigned-clock* is a property of the SoC this driver..

drivers/media/i2c/hi846.c
         mclk_freq = clk_get_rate(hi846->clock);
         if (mclk_freq != 25000000)
                 dev_warn(&client->dev,
                          "External clock freq should be 25000000, not 
%u.\n",
                          mclk_freq);

doesn't support setting the clock.

So it actually is a requirement, yes.

---
bod