linux-kernel - 回覆: [net] net: ftgmac100: refactor getting phy device handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB513444FDA713972EFC05FBFD9D442@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Mon, 14 Oct 2024 02:38:56 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "jacob.e.keller@...el.com"
	<jacob.e.keller@...el.com>, "rentao.bupt@...il.com" <rentao.bupt@...il.com>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>, "andrew@...id.au"
	<andrew@...id.au>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject:
 回覆: [net] net: ftgmac100: refactor getting phy device handle

Hi Andrew,

Thanks for the review.

> > The ftgmac100 supports NC-SI mode, dedicated PHY and fixed-link PHY.
> > The dedicated PHY is using the phy_handle property to get phy device
> > handle and the fixed-link phy is using the fixed-link property to
> > register a fixed-link phy device.
> >
> > In of_phy_get_and_connect function, it help driver to get and register
> > these PHYs handle.
> > Therefore, here refactors this part by using of_phy_get_and_connect.
> >
> > Fixes: 38561ded50d0 ("net: ftgmac100: support fixed link")
> > Fixes: 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle
> > property")
> 
> Fixes: implies something is broken. What is actually wrong with this code?
> What sort of problem does a user see?

I am apology what I am not sure if using fixes to send my patch.
I just refactor this part and let the relevant people know that I have adjusted 
their code.
This patch is not a bug fix.

> 
> > -		phy_support_asym_pause(phy);
> > +		if (of_get_property(np, "phy-handle", NULL))
> > +			phy_support_asym_pause(phy);
> 
> This is probably wrong. This is the MAC layer telling phylib that the MAC
> supports asym pause. It should makes no difference to the MAC what sort of
> PHY is being used, all the MAC is looking at/sending is pause frames.

Agree. It is MAC function, not PHY.
I will adjust it on next version.
Thank you.