linux-kernel - Re: [PATCH 10/17] can: gw: replace call_rcu by kfree_rcu for simple kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZ6RqL2+srRF15spoLqXhe40w02TEDpAzb+gnbVgD-os-f87Q@mail.gmail.com>
Date: Mon, 14 Oct 2024 12:03:51 +0900
From: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
To: Julia Lawall <Julia.Lawall@...ia.fr>
Cc: Oliver Hartkopp <socketcan@...tkopp.net>, kernel-janitors@...r.kernel.org, vbabka@...e.cz, 
	"Paul E . McKenney" <paulmck@...nel.org>, Marc Kleine-Budde <mkl@...gutronix.de>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	linux-can <linux-can@...r.kernel.org>, netdev <netdev@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/17] can: gw: replace call_rcu by kfree_rcu for simple
 kmem_cache_free callback

Hi Julia,

Thanks for the patch.

On Mon. 14 Oct. 2024, 05:21, Julia Lawall <Julia.Lawall@...ia.fr> wrote:
> Since SLOB was removed and since
> commit 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"),
> it is not necessary to use call_rcu when the callback only performs
> kmem_cache_free. Use kfree_rcu() directly.
>
> The changes were made using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>