linux-kernel - Re: [PATCH] media: atomisp: remove redundant re-checking of err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zw0Btri2dydmt3W3@smile.fi.intel.com>
Date: Mon, 14 Oct 2024 14:34:14 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Hans de Goede <hdegoede@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] media: atomisp: remove redundant re-checking of err

On Sat, Oct 12, 2024 at 03:14:03PM +0100, Colin Ian King wrote:
> The check to see if err is non-zero is always false because err has
> been previously checked on whenever err has been assigned in previous
> code paths. The check is redundant and can be removed.

Reviewed-by: Andy Shevchenko <andy@...nel.org>

All patches that end up in 100% minus lines statistics for this driver are so good!

-- 
With Best Regards,
Andy Shevchenko