linux-kernel - Re: [PATCH] watchdog: Delete the cpu5wdt driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <424ffa29-5d05-4a58-9fd1-09ae177ad781@roeck-us.net>
Date: Tue, 15 Oct 2024 07:05:14 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Jean Delvare <jdelvare@...e.de>, linux-watchdog@...r.kernel.org
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] watchdog: Delete the cpu5wdt driver

On 10/15/24 04:37, Jean Delvare wrote:
> This driver has a number of issues (accesses arbitrary I/O ports
> without identifying the hardware, doesn't document what hardware it
> supports, suspiciously inconsistent locking model, doesn't implement
> WDIOC_SETTIMEOUT, potential integer overflow...)
> 
> The driver was added in 2003 and there's no evidence that it has any
> recent user, all changes seem to be tree-wide, subsystem-wide, or the
> result of static code analysis. So I believe we should simply drop
> this legacy piece of code.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Message-ID: <20241011170710.484a257a@...ymion.delvare>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Ultimately we should consider removing all watchdog drivers not implementing
the watchdog API, or at least declare them deprecated.

Guenter