linux-kernel - Re: [PATCH RFC/RFT 1/3] dt-bindings: touchscreen: Add binding for Novatek NT36xxx series driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172900242289.881163.3310212462918589940.robh@kernel.org>
Date: Tue, 15 Oct 2024 09:27:02 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: George Chan <gchan9527@...il.com>
Cc: devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Henrik Rydberg <rydberg@...math.org>, linux-input@...r.kernel.org, 
 Del Regno <kholk11@...il.com>, linux-kernel@...r.kernel.org, 
 Dmitry Torokhov <dmitry.torokhov@...il.com>, 
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH RFC/RFT 1/3] dt-bindings: touchscreen: Add binding for
 Novatek NT36xxx series driver


On Tue, 15 Oct 2024 20:53:29 +0800, George Chan wrote:
> Add binding for the Novatek NT36xxx series touchscreen driver.
> 
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@...il.com>
> Signed-off-by: George Chan <gchan9527@...il.com>
> ---
>  .../bindings/input/touchscreen/nt36xxx.yaml        | 70 ++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/input/touchscreen/nt36xxx.yaml:19:9: [warning] wrong indentation: expected 6 but found 8 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/nt36xxx.yaml: title: 'Novatek NT36xxx series touchscreen controller Bindings' should not be valid under {'pattern': '([Bb]inding| [Ss]chema)'}
	hint: Everything is a binding/schema, no need to say it. Describe what hardware the binding is for.
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241015-nt36xxx-v1-1-3919d0bffee6@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.