linux-kernel - RE: [PATCH v3 2/2] irqchip/aspeed-intc: Add support for AST27XX INTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-8fef4ba2-f5ab-4b78-b3de-aa1dc7d2fa33-1729004844102@3c-app-webde-bap19>
Date: Tue, 15 Oct 2024 17:07:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Kevin Chen <kevin_chen@...eedtech.com>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-aspeed@...ts.ozlabs.org
Cc: Andrew Jeffery <andrew@...econstruct.com.au>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, Thomas Gleixner
 <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>, BMC-SW
 <BMC-SW@...eedtech.com>, kernel-janitors@...r.kernel.org
Subject: RE: [PATCH v3 2/2] irqchip/aspeed-intc: Add support for AST27XX
 INTC

…
> > > +static void aspeed_intc_ic_irq_handler(struct irq_desc *desc) {
…
> > > +       guard(chained_irq)(desc);
> > 
> > Using another macro call “scoped_guard(…) { … }”?
> Is it necessary to use scoped_guard(...) {...}?

It depends on corresponding case disintions.


> > > +       scoped_guard(raw_spinlock, &intc_ic->gic_lock) {
> > 
> > Would you like to reconsider the proposed macro mixture once more?
> Could I check the reason for once more?

Coding style concerns …?


> > > +++ b/include/linux/irqchip/chained_irq.h
> > > @@ -38,4 +38,6 @@ static inline void chained_irq_exit(struct irq_chip *chip,
> > >                 chip->irq_unmask(&desc->irq_data);
> > >  }
> > >
> > > +DEFINE_GUARD(chained_irq, struct irq_desc *,
> > chained_irq_exit((_T->irq_data.chip), (_T)),
> > > +            chained_irq_enter((_T->irq_data.chip), (_T)))
> > 
> > Would you like to add a #include directive in this header file accordingly?
> Can you give me an example?

See also:
https://elixir.bootlin.com/linux/v6.12-rc3/source/include/linux/device.h#L33

Regards,
Markus