linux-kernel - Re: [PATCH 1/3] selftests: Add a few missing gitignore files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <087279ce-7fd0-49f3-b578-2d1b82852e3d@linuxfoundation.org>
Date: Tue, 15 Oct 2024 09:38:14 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Li Zhijian <lizhijian@...itsu.com>, linux-kselftest@...r.kernel.org,
 Shuah Khan <shuah@...nel.org>
Cc: linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/3] selftests: Add a few missing gitignore files

On 10/14/24 19:08, Li Zhijian wrote:
> Binary files should be added to .gitignore
> 
> 'git status' complains:
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
>       alsa/global-timer
>       alsa/utimer-test
>       filesystems/statmount/statmount_test_ns
>       mm/hugetlb_dio
>       mm/pkey_sighandler_tests_32
>       mm/pkey_sighandler_tests_64
>       net/netfilter/conntrack_reverse_clash
> 
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
>   tools/testing/selftests/alsa/.gitignore                  | 2 ++
>   tools/testing/selftests/filesystems/statmount/.gitignore | 1 +
>   tools/testing/selftests/mm/.gitignore                    | 2 ++
>   tools/testing/selftests/net/netfilter/.gitignore         | 1 +

You are sending 3 patches without a cover letter and you are missing
key people who should review the patches.

Combining several subsystem changes in one patch leads to merge
conflicts.

Run get_maintainers to see who all the patch should be sent.

>   4 files changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/alsa/.gitignore b/tools/testing/selftests/alsa/.gitignore
> index 12dc3fcd3456..1407fd24a97b 100644
> --- a/tools/testing/selftests/alsa/.gitignore
> +++ b/tools/testing/selftests/alsa/.gitignore
> @@ -1,3 +1,5 @@
>   mixer-test
>   pcm-test
>   test-pcmtest-driver
> +global-timer
> +utimer-test
> diff --git a/tools/testing/selftests/filesystems/statmount/.gitignore b/tools/testing/selftests/filesystems/statmount/.gitignore
> index 82a4846cbc4b..66a21f289453 100644
> --- a/tools/testing/selftests/filesystems/statmount/.gitignore
> +++ b/tools/testing/selftests/filesystems/statmount/.gitignore
> @@ -1,2 +1,3 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   /*_test
> +statmount_test_ns
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index da030b43e43b..2ac11b7fcb26 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -51,3 +51,5 @@ hugetlb_madv_vs_map
>   mseal_test
>   seal_elf
>   droppable
> +hugetlb_dio
> +pkey_sighandler_tests*
> diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore
> index 0a64d6d0e29a..eef8d5784e94 100644
> --- a/tools/testing/selftests/net/netfilter/.gitignore
> +++ b/tools/testing/selftests/net/netfilter/.gitignore
> @@ -4,3 +4,4 @@ connect_close
>   conntrack_dump_flush
>   sctp_collision
>   nf_queue
> +conntrack_reverse_clash

thanks,
-- Shuah