linux-kernel - Re: [PATCH 1/2] dt-bindings: pwm: brcm,bcm7038: Document the 'open-drain' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <252b6f39-3b06-43b7-b227-1c29c1c12bd5@gmail.com>
Date: Tue, 15 Oct 2024 10:07:10 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Rob Herring <robh@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-kernel@...r.kernel.org,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Thierry Reding <thierry.reding@...il.com>,
 "open list:PWM SUBSYSTEM" <linux-pwm@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
 <linux-arm-kernel@...ts.infradead.org>, justin.chen@...adcom.com
Subject: Re: [PATCH 1/2] dt-bindings: pwm: brcm,bcm7038: Document the
 'open-drain' property

On 10/15/24 09:32, Rob Herring wrote:
> On Fri, Oct 11, 2024 at 07:56:02PM -0700, Florian Fainelli wrote:
>> Document the 'open-drain' property that allows configuring the PWM
>> controller outputs in open drain versus totem pole.
>>
>> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
>> ---
>>   Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
>> index 119de3d7f9dd..12851c43a612 100644
>> --- a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
>> @@ -25,6 +25,12 @@ properties:
>>     clocks:
>>       maxItems: 1
>>   
>> +  open-drain:
>> +    type: boolean
>> +    description:
>> +      Configure the outputs with open-drain structure, if omitted totem pole
>> +      structure is used.
>> +
> 
> There's one other PWM with 'open-drain' so move the definition to
> pwm.yaml.

Ah indeed, there is one now, great.

> 
> Alternatively, 'drive-open-drain' is a much more commonly used
> variation.

That name works just as well.

> 
> Another thing to consider is for any PWM controller with more than
> 1 output, you might want this to be per output and therefore should be
> a flag in the cells.

Yes, that is a good point, this controller has two channels, so it seems 
like increasing the #pwm-cells might be the way to go.

Thanks!
-- 
Florian