linux-kernel - Re: [PATCH 1/2] net: systemport: Remove unused txchk accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25cb1dfb-a0dd-44d9-ac35-bfbc66a82d1f@broadcom.com>
Date: Tue, 15 Oct 2024 10:32:21 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:CLANG/LLVM BUILD SUPPORT:" <llvm@...ts.linux.dev>
Subject: Re: [PATCH 1/2] net: systemport: Remove unused txchk accessors

On 10/15/24 10:29, Vladimir Oltean wrote:
> On Tue, Oct 15, 2024 at 10:24:57AM -0700, Florian Fainelli wrote:
>> Vladimir reported the following warning with clang-16 and W=1:
>>
>> warning: unused function 'txchk_readl' [-Wunused-function]
>> BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET);
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
>>
>> warning: unused function 'txchk_writel' [-Wunused-function]
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
>>
>> warning: unused function 'tbuf_readl' [-Wunused-function]
>> BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET);
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
>>
>> warning: unused function 'tbuf_writel' [-Wunused-function]
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
> 
> I mean the warnings do say that the tbuf macros are unused too, yet you
> only remove txchk? I did ask yesterday if that should also be deleted,
> and with it the other unused transmit buffer macros?
> https://lore.kernel.org/netdev/20241014174056.sxcgikf4hhw2olp7@skbuf/

See my response to my own posting.
--
Florian