linux-kernel - Re: [PATCH] pinctrl: th1520: add a CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zw6rL508BnZRwBvC@x1>
Date: Tue, 15 Oct 2024 10:49:35 -0700
From: Drew Fustini <drew@...7.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Emil Renner Berthing <emil.renner.berthing@...onical.com>,
	Drew Fustini <dfustini@...storrent.com>,
	Arnd Bergmann <arnd@...db.de>, Andy Shevchenko <andy@...nel.org>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: th1520:  add a CONFIG_OF dependency

On Tue, Oct 15, 2024 at 03:11:13PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When compile-testing without CONfIG_OF:
> 
> drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':
> drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]
>   455 |                 ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                       pinconf_generic_dump_config
> 
> Enforce this using Kconig dependencies.
> 
> Fixes: bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/pinctrl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index a6acc27c9a83..3fab5ebeb2e0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -564,6 +564,7 @@ config PINCTRL_TPS6594
>  config PINCTRL_TH1520
>  	tristate "Pinctrl driver for the T-Head TH1520 SoC"
>  	depends on ARCH_THEAD || COMPILE_TEST
> +	depends on OF
>  	select GENERIC_PINMUX_FUNCTIONS
>  	select GENERIC_PINCONF
>  	select PINMUX
> -- 
> 2.39.5
> 

Thank you for fixing this.

Acked-by: Drew Fustini <drew@...7.com>