linux-kernel - Re: [PATCH 2/2] mailbox: ti-msgmgr: Allow building under COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1a88e7b5-582f-4d52-864a-e828f6619bc8@app.fastmail.com>
Date: Tue, 15 Oct 2024 20:54:45 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "kernel test robot" <lkp@...el.com>, "Andrew Davis" <afd@...com>,
 "Jassi Brar" <jassisinghbrar@...il.com>,
 "Bjorn Andersson" <andersson@...nel.org>,
 "Mathieu Poirier" <mathieu.poirier@...aro.org>,
 "Martyn Welch" <martyn.welch@...labora.com>, "Hari Nagalla" <hnagalla@...com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mailbox: ti-msgmgr: Allow building under COMPILE_TEST

Hi Andrew,

On Tue, Oct 15, 2024, at 20:46, kernel test robot wrote:
>    In file included from drivers/firmware/ti_sci.c:14:
>    In file included from include/linux/io.h:14:
>    In file included from arch/hexagon/include/asm/io.h:328:
>    include/asm-generic/io.h:548:31: warning: performing pointer 
> arithmetic on a null pointer has undefined behavior 
> [-Wnull-pointer-arithmetic]
>      548 |         val = __raw_readb(PCI_IOBASE + addr);
>          |                           ~~~~~~~~~~ ^
>    include/asm-generic/io.h:561:61: warning: performing pointer 
> arithmetic on a null pointer has undefined behavior 
> [-Wnull-pointer-arithmetic]
>      561 |         val = __le16_to_cpu((__le16 
> __force)__raw_readw(PCI_IOBASE + addr));
>          |                                                         


Hopefully we will be able to finally address these in 6.13
for all drivers, it's been a decade. Don't worry about
the above.


> platform_device *dev,
>          |                    ^~~~~~~~~~~~~~~~~~~~~~
>>> drivers/firmware/ti_sci.c:3285:34: warning: unused variable 'ti_sci_of_match' [-Wunused-const-variable]
>     3285 | static const struct of_device_id ti_sci_of_match[] = {
>          |                                  ^~~~~~~~~~~~~~~
>    8 warnings generated.
>

Needs this change, please fold into your patch.

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 160968301b1f..6a6bf7a2d134 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -3421,7 +3421,7 @@ static struct platform_driver ti_sci_driver = {
        .probe = ti_sci_probe,
        .driver = {
                   .name = "ti-sci",
-                  .of_match_table = of_match_ptr(ti_sci_of_match),
+                  .of_match_table = ti_sci_of_match,
                   .suppress_bind_attrs = true,
        },
 };