[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241015205637.GB1934266-robh@kernel.org>
Date: Tue, 15 Oct 2024 15:56:37 -0500
From: Rob Herring <robh@...nel.org>
To: Macpaul Lin <macpaul.lin@...iatek.com>
Cc: Chunfeng Yun <chunfeng.yun@...iatek.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
ChiYuan Huang <cy_huang@...htek.com>, linux-usb@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Bear Wang <bear.wang@...iatek.com>,
Pablo Sun <pablo.sun@...iatek.com>, Macpaul Lin <macpaul@...il.com>,
Project_Global_Chrome_Upstream_Group@...iatek.com,
Chris-qj chen <chris-qj.chen@...iatek.com>,
Fabien Parent <fparent@...libre.com>,
Simon Sun <simon.sun@...jingtech.com>
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add
support for TCPC port
On Tue, Oct 15, 2024 at 06:33:37PM +0800, Macpaul Lin wrote:
> From: Fabien Parent <fparent@...libre.com>
>
> Enable USB Type-C support on MediaTek MT8395 Genio 1200 EVK by adding
> configuration for TCPC Port, USB-C connector, and related settings.
>
> Configure dual role switch capability, set up PD (Power Delivery) profiles,
> and establish endpoints for SSUSB (SuperSpeed USB).
>
> Update pinctrl configurations for U3 P0 VBus default pins and set dr_mode
> to "otg" for OTG (On-The-Go) mode operation.
>
> Signed-off-by: Fabien Parent <fparent@...libre.com>
> Signed-off-by: Simon Sun <simon.sun@...jingtech.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> ---
> .../dts/mediatek/mt8395-genio-1200-evk.dts | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> index 5f16fb820580..b91a46f4a702 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> @@ -249,6 +249,39 @@ mt6360: pmic@34 {
> #interrupt-cells = <1>;
> pinctrl-0 = <&mt6360_pins>;
>
> + tcpc {
> + compatible = "mediatek,mt6360-tcpc";
> + interrupts-extended = <&pio 17 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "PD_IRQB";
> +
> + connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> + power-role = "dual";
> + try-power-role = "sink";
> + source-pdos = <PDO_FIXED(5000, 1000, \
> + PDO_FIXED_DUAL_ROLE | \
> + PDO_FIXED_DATA_SWAP)>;
> + sink-pdos = <PDO_FIXED(5000, 2000, \
> + PDO_FIXED_DUAL_ROLE | \
> + PDO_FIXED_DATA_SWAP)>;
> + op-sink-microwatt = <10000000>;
> + };
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + mt6360_ssusb_ep: endpoint {
> + remote-endpoint = <&ssusb_ep>;
No, this is wrong. This should go to 'port@1' in the connector node.
That is the SS connection.
Rob
Powered by blists - more mailing lists