| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241015-ep-msi-v3-3-cedc89a16c1a@nxp.com>
Date: Tue, 15 Oct 2024 18:07:16 -0400
From: Frank Li <Frank.Li@....com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>, Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
imx@...ts.linux.dev, Niklas Cassel <cassel@...nel.org>, dlemoal@...nel.org,
maz@...nel.org, tglx@...utronix.de, jdmason@...zu.us,
Frank Li <Frank.Li@....com>
Subject: [PATCH v3 3/6] PCI: endpoint: Add RC-to-EP doorbell support using
platform MSI controller
Doorbell feature is implemented by mapping the EP's MSI interrupt
controller message address to a dedicated BAR in the EPC core. It is the
responsibility of the EPF driver to pass the actual message data to be
written by the host to the doorbell BAR region through its own logic.
Signed-off-by: Frank Li <Frank.Li@....com>
---
drivers/pci/endpoint/Makefile | 2 +-
drivers/pci/endpoint/pci-ep-msi.c | 162 ++++++++++++++++++++++++++++++++++++++
include/linux/pci-ep-msi.h | 15 ++++
include/linux/pci-epf.h | 6 ++
4 files changed, 184 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/Makefile b/drivers/pci/endpoint/Makefile
index 95b2fe47e3b06..a1ccce440c2c5 100644
--- a/drivers/pci/endpoint/Makefile
+++ b/drivers/pci/endpoint/Makefile
@@ -5,4 +5,4 @@
obj-$(CONFIG_PCI_ENDPOINT_CONFIGFS) += pci-ep-cfs.o
obj-$(CONFIG_PCI_ENDPOINT) += pci-epc-core.o pci-epf-core.o\
- pci-epc-mem.o functions/
+ pci-epc-mem.o pci-ep-msi.o functions/
diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c
new file mode 100644
index 0000000000000..534dcd05c435c
--- /dev/null
+++ b/drivers/pci/endpoint/pci-ep-msi.c
@@ -0,0 +1,162 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * PCI Endpoint *Controller* (EPC) MSI library
+ *
+ * Copyright (C) 2024 NXP
+ * Author: Frank Li <Frank.Li@....com>
+ */
+
+#include <linux/cleanup.h>
+#include <linux/device.h>
+#include <linux/slab.h>
+#include <linux/module.h>
+
+#include <linux/msi.h>
+#include <linux/pci-epc.h>
+#include <linux/pci-epf.h>
+#include <linux/pci-ep-cfs.h>
+#include <linux/pci-ep-msi.h>
+
+static irqreturn_t pci_epf_doorbell_handler(int irq, void *data)
+{
+ struct pci_epf *epf = data;
+ struct msi_desc *desc = irq_get_msi_desc(irq);
+
+ if (desc && epf->event_ops && epf->event_ops->doorbell)
+ epf->event_ops->doorbell(epf, desc->msi_index);
+
+ return IRQ_HANDLED;
+}
+
+static bool pci_epc_match_parent(struct device *dev, void *param)
+{
+ return dev->parent == param;
+}
+
+static void pci_epc_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
+{
+ struct pci_epc *epc __free(pci_epc_put) = NULL;
+ struct pci_epf *epf;
+
+ epc = pci_epc_get_fn(pci_epc_match_parent, desc->dev);
+
+ if (!epc)
+ return;
+
+ /* Only support one EPF for doorbell */
+ epf = list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list);
+ if (!epf)
+ return;
+
+ if (epf->msg && desc->msi_index < epf->num_db)
+ memcpy(epf->msg, msg, sizeof(*msg));
+}
+
+static int pci_epc_alloc_doorbell(struct pci_epc *epc, u8 func_no, u8 vfunc_no, int num_db)
+{
+ struct msi_desc *desc, *failed_desc;
+ struct pci_epf *epf;
+ struct device *dev;
+ int i = 0;
+ int ret;
+
+ if (IS_ERR_OR_NULL(epc))
+ return -EINVAL;
+
+ /* Currently only support one func and one vfunc for doorbell */
+ if (func_no || vfunc_no)
+ return -EINVAL;
+
+ epf = list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list);
+ if (!epf)
+ return -EINVAL;
+
+ dev = epc->dev.parent;
+ ret = platform_device_msi_init_and_alloc_irqs(dev, num_db, pci_epc_write_msi_msg);
+ if (ret) {
+ dev_err(dev, "Failed to allocate MSI\n");
+ return -ENOMEM;
+ }
+
+ scoped_guard(msi_descs, dev)
+ msi_for_each_desc(desc, dev, MSI_DESC_ALL) {
+ ret = request_irq(desc->irq, pci_epf_doorbell_handler, 0,
+ kasprintf(GFP_KERNEL, "pci-epc-doorbell%d", i++), epf);
+ if (ret) {
+ dev_err(dev, "Failed to request doorbell\n");
+ failed_desc = desc;
+ goto err_request_irq;
+ }
+ }
+
+ return 0;
+
+err_request_irq:
+ scoped_guard(msi_descs, dev)
+ msi_for_each_desc(desc, dev, MSI_DESC_ALL) {
+ if (desc == failed_desc)
+ break;
+ kfree(free_irq(desc->irq, epf));
+ }
+
+ platform_device_msi_free_irqs_all(epc->dev.parent);
+
+ return ret;
+}
+
+static void pci_epc_free_doorbell(struct pci_epc *epc, u8 func_no, u8 vfunc_no)
+{
+ struct msi_desc *desc;
+ struct pci_epf *epf;
+ struct device *dev;
+
+ dev = epc->dev.parent;
+
+ scoped_guard(msi_descs, dev)
+ msi_for_each_desc(desc, dev, MSI_DESC_ALL)
+ kfree(free_irq(desc->irq, epf));
+
+ platform_device_msi_free_irqs_all(epc->dev.parent);
+}
+
+int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)
+{
+ struct pci_epc *epc;
+ struct device *dev;
+ void *msg;
+ int ret;
+
+ epc = epf->epc;
+ dev = &epc->dev;
+
+ guard(mutex)(&epc->lock);
+
+ msg = kcalloc(num_db, sizeof(struct msi_msg), GFP_KERNEL);
+ if (!msg)
+ return -ENOMEM;
+
+ epf->num_db = num_db;
+ epf->msg = msg;
+
+ ret = pci_epc_alloc_doorbell(epc, epf->func_no, epf->vfunc_no, num_db);
+ if (ret)
+ kfree(msg);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(pci_epf_alloc_doorbell);
+
+void pci_epf_free_doorbell(struct pci_epf *epf)
+{
+ struct pci_epc *epc = epf->epc;
+
+ guard(mutex)(&epc->lock);
+
+ epc = epf->epc;
+ pci_epc_free_doorbell(epc, epf->func_no, epf->vfunc_no);
+
+ kfree(epf->msg);
+ epf->msg = NULL;
+ epf->num_db = 0;
+}
+EXPORT_SYMBOL_GPL(pci_epf_free_doorbell);
diff --git a/include/linux/pci-ep-msi.h b/include/linux/pci-ep-msi.h
new file mode 100644
index 0000000000000..f0cfecf491199
--- /dev/null
+++ b/include/linux/pci-ep-msi.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * PCI Endpoint *Function* side MSI header file
+ *
+ * Copyright (C) 2024 NXP
+ * Author: Frank Li <Frank.Li@....com>
+ */
+
+#ifndef __PCI_EP_MSI__
+#define __PCI_EP_MSI__
+
+int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 nums);
+void pci_epf_free_doorbell(struct pci_epf *epf);
+
+#endif /* __PCI_EP_MSI__ */
diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h
index 18a3aeb62ae4e..1e7e5eb4067d7 100644
--- a/include/linux/pci-epf.h
+++ b/include/linux/pci-epf.h
@@ -75,6 +75,7 @@ struct pci_epf_ops {
* @link_up: Callback for the EPC link up event
* @link_down: Callback for the EPC link down event
* @bus_master_enable: Callback for the EPC Bus Master Enable event
+ * @doorbell: Callback for EPC receive MSI from RC side
*/
struct pci_epc_event_ops {
int (*epc_init)(struct pci_epf *epf);
@@ -82,6 +83,7 @@ struct pci_epc_event_ops {
int (*link_up)(struct pci_epf *epf);
int (*link_down)(struct pci_epf *epf);
int (*bus_master_enable)(struct pci_epf *epf);
+ int (*doorbell)(struct pci_epf *epf, int index);
};
/**
@@ -152,6 +154,8 @@ struct pci_epf_bar {
* @vfunction_num_map: bitmap to manage virtual function number
* @pci_vepf: list of virtual endpoint functions associated with this function
* @event_ops: Callbacks for capturing the EPC events
+ * @msg: data for MSI from RC side
+ * @num_db: number of doorbells
*/
struct pci_epf {
struct device dev;
@@ -182,6 +186,8 @@ struct pci_epf {
unsigned long vfunction_num_map;
struct list_head pci_vepf;
const struct pci_epc_event_ops *event_ops;
+ struct msi_msg *msg;
+ u16 num_db;
};
/**
--
2.34.1
Powered by blists - more mailing lists