linux-kernel - Re: [PATCH v4 3/4] power: supply: initial support for TWL6030/32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ucahlofrnajeb7z3tmkx2aninkxpbwx3mdykeeugtsct2o5gh@5dxrvnl23dsy>
Date: Wed, 16 Oct 2024 00:11:15 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: devicetree@...r.kernel.org, Lee Jones <lee@...nel.org>, 
	linux-kernel@...r.kernel.org, tony@...mide.com, Rob Herring <robh@...nel.org>, 
	linux-pm@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, khilman@...libre.com, 
	linux-omap@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v4 3/4] power: supply: initial support for TWL6030/32

Hi,

On Mon, Oct 07, 2024 at 05:01:19PM +0200, Andreas Kemnade wrote:
> Add a driver for the charger in the TWL6030/32. For now it does not report
> much in sysfs but parameters are set up for USB, charging is enabled with
> the specified parameters. It stops charging when full and also restarts
> charging.
> This prevents ending up in a system setup where you run out of battery
> although a charger is plugged in after precharge completed.
> 
> Battery voltage behavior was checked via the GPADC.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---

Looks mostly good, but the driver should set the fwnode for the
power_supply device to be ready for better battery support in
the future:

psy_cfg.fwnode = dev_fwnode(&pdev->dev);

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)