linux-kernel - Re: [PATCH 5/8] perf tools: Detect missing kernel features properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97fd7f8c-8593-4018-a1a0-f85e8e4957aa@amd.com>
Date: Tue, 15 Oct 2024 09:49:52 +0530
From: Ravi Bangoria <ravi.bangoria@....com>
To: Namhyung Kim <namhyung@...nel.org>,
 Arnaldo Carvalho de Melo <acme@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Kan Liang <kan.liang@...ux.intel.com>
Cc: Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>,
 LKML <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org,
 Mark Rutland <mark.rutland@....com>, James Clark <james.clark@....com>,
 Kajol Jain <kjain@...ux.ibm.com>, Thomas Richter <tmricht@...ux.ibm.com>,
 Atish Patra <atishp@...shpatra.org>, Palmer Dabbelt <palmer@...osinc.com>,
 Mingwei Zhang <mizhang@...gle.com>, Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH 5/8] perf tools: Detect missing kernel features properly

> -	} else if (evsel->core.attr.exclude_guest || evsel->core.attr.exclude_host) {
> -		if (evsel->pmu == NULL)
> -			evsel->pmu = evsel__find_pmu(evsel);
> -
> -		if (evsel->pmu)
> -			evsel->pmu->missing_features.exclude_guest = true;
> -		else {
> -			/* we cannot find PMU, disable attrs now */
> -			evsel->core.attr.exclude_host = false;
> -			evsel->core.attr.exclude_guest = false;
> -		}
>  
> -		if (evsel->exclude_GH) {
> -			pr_debug2_peo("PMU has no exclude_host/guest support, bailing out\n");
> -			return false;
> -		}
> -		if (!perf_missing_features.exclude_guest) {
> -			perf_missing_features.exclude_guest = true;
> -			pr_debug2_peo("switching off exclude_guest, exclude_host\n");
> -		}

Shall we get rid of:

  perf_missing_features.exclude_guest
  pmu->missing_features.exclude_guest

they don't seem to be used anywhere after the patch.

Thanks,
Ravi