linux-kernel - Re: [PATCH v2 2/7] streamline_config.pl: ensure all defaults are tracked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241015190929.077535b4@gandalf.local.home>
Date: Tue, 15 Oct 2024 19:09:29 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: David Hunter <david.hunter.linux@...il.com>
Cc: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org,
 linux-kernel@...r.kernel.org, shuah@...nel.org,
 javier.carrasco.cruz@...il.com
Subject: Re: [PATCH v2 2/7] streamline_config.pl: ensure all defaults are
 tracked

On Mon, 14 Oct 2024 10:13:32 -0400
David Hunter <david.hunter.linux@...il.com> wrote:

Hi David,

Thanks for sending these.

> Track default options on the second line. On the second line of some
> config entries, default and depndency options sometimes appear. In those
			      "dependency"

> instances, the state will be "NEW" and not "DEP".

Can you list some examples of where this happens?

Thanks,

-- Steve

> 
> Signed-off-by: David Hunter <david.hunter.linux@...il.com>
> ---
> V1 https://lore.kernel.org/all/20240913171205.22126-4-david.hunter.linux@gmail.com/
> 
> V2
> 	- changed the subject
> 	- changed the condition to be more in line with the script style 
> ---
>  scripts/kconfig/streamline_config.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index a85d6a3108a1..85f4712e2bf3 100755
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -220,7 +220,7 @@ sub read_kconfig {
>  	    $depends{$config} = $1;
>  	} elsif ($state eq "DEP" && /^\s*depends\s+on\s+(.*)$/) {
>  	    $depends{$config} .= " " . $1;
> -	} elsif ($state eq "DEP" && /^\s*def(_(bool|tristate)|ault)\s+(\S.*)$/) {
> +	} elsif ($state ne "NONE" && /^\s*def(_(bool|tristate)|ault)\s+(\S.*)$/) {
>  	    my $dep = $3;
>  	    if ($dep !~ /^\s*(y|m|n)\s*$/) {
>  		$dep =~ s/.*\sif\s+//;