linux-kernel - Re: [PATCH v16 01/18] tracing: Use arch_ftrace_regs() for ftrace_regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241016082541.6d5d278d425e05b8295c0193@kernel.org>
Date: Wed, 16 Oct 2024 08:25:41 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Florent Revest
 <revest@...omium.org>, linux-trace-kernel@...r.kernel.org, LKML
 <linux-kernel@...r.kernel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
 bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Jiri Olsa
 <jolsa@...nel.org>, Alan Maguire <alan.maguire@...cle.com>, Mark Rutland
 <mark.rutland@....com>, linux-arch@...r.kernel.org
Subject: Re: [PATCH v16 01/18] tracing: Use arch_ftrace_regs() for
 ftrace_regs_*() macros

On Tue, 15 Oct 2024 17:27:57 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> 
> FYI, for anything to do with function hooks (fentry), the subject should be
> "ftrace:" not "tracing:".

Ah, yes.

> 
> Tracing has to do with the tracing infrastructure, whereas ftrace is the
> function hook infrastructure.
> 
> I just accepted the first two patches of this series and made the changes
> to the subjects.

OK, thanks!

> 
> If a change is for function graph infrastructure specifically, you can use
> "fgraph:" instead.

Just to confirm, is "function_graph:" for function graph tracer itself?

Thank you,

> 
> -- Steve
> 
> 
> On Tue, 15 Oct 2024 10:28:43 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > 
> > Since the arch_ftrace_get_regs(fregs) is only valid when the
> > FL_SAVE_REGS is set, we need to use `&arch_ftrace_regs()->regs` for
> > ftrace_regs_*() APIs because those APIs are for ftrace_regs, not
> > complete pt_regs.
> > 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>