linux-kernel - Re: [REGRESSION] alg: ahash: Several tests fail during boot on Turris Omnia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zw31JIEyh28vK9q7@gondor.apana.org.au>
Date: Tue, 15 Oct 2024 12:52:52 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Klaus Kudielka <klaus.kudielka@...il.com>
Cc: regressions@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	Arnaud Ebalard <arno@...isbad.org>,
	Romain Perier <romain.perier@...e-electrons.com>
Subject: Re: [REGRESSION] alg: ahash: Several tests fail during boot on
 Turris Omnia

On Thu, Oct 10, 2024 at 07:35:33PM +0200, Klaus Kudielka wrote:
>
> Hmmm, not really (patch applied on top of 6.12-rc2). 5 algorithms failed self-test.

OK, let's try disabling TDMA altogether.  And if it still fails with
this could you please bring back the printk patch and send me the
result of it with TDMA disabled please?

Thanks!

diff --git a/drivers/crypto/marvell/cesa/cesa.c b/drivers/crypto/marvell/cesa/cesa.c
index 5fd31ba715c2..a3f0465aa178 100644
--- a/drivers/crypto/marvell/cesa/cesa.c
+++ b/drivers/crypto/marvell/cesa/cesa.c
@@ -278,7 +278,7 @@ static const struct mv_cesa_caps kirkwood_caps = {
 	.ncipher_algs = ARRAY_SIZE(orion_cipher_algs),
 	.ahash_algs = orion_ahash_algs,
 	.nahash_algs = ARRAY_SIZE(orion_ahash_algs),
-	.has_tdma = true,
+	.has_tdma = false,
 };
 
 static const struct mv_cesa_caps armada_370_caps = {
@@ -287,7 +287,7 @@ static const struct mv_cesa_caps armada_370_caps = {
 	.ncipher_algs = ARRAY_SIZE(armada_370_cipher_algs),
 	.ahash_algs = armada_370_ahash_algs,
 	.nahash_algs = ARRAY_SIZE(armada_370_ahash_algs),
-	.has_tdma = true,
+	.has_tdma = false,
 };
 
 static const struct mv_cesa_caps armada_xp_caps = {
@@ -296,7 +296,7 @@ static const struct mv_cesa_caps armada_xp_caps = {
 	.ncipher_algs = ARRAY_SIZE(armada_370_cipher_algs),
 	.ahash_algs = armada_370_ahash_algs,
 	.nahash_algs = ARRAY_SIZE(armada_370_ahash_algs),
-	.has_tdma = true,
+	.has_tdma = false,
 };
 
 static const struct of_device_id mv_cesa_of_match_table[] = {
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt