linux-kernel - Re: [PATCH] dma/dw-edma: chip regs base should add the offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241015053608.h2avloxfak5yagyd@thinkpad>
Date: Tue, 15 Oct 2024 11:06:08 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: ChunyouTang <tangchunyou@....com>
Cc: fancer.lancer@...il.com, vkoul@...nel.org, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma/dw-edma: chip regs base should add the offset

On Mon, Oct 14, 2024 at 09:48:32PM +0800, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@....com>
> 
> fix the regs base with offset.
> 

Initially I thought that this patch is a spam, but it is not. It is indeed
fixing a real bug in the driver. But the subject and description made it look
like a spam. Please follow the process defined in:
Documentation/process/5.Posting.rst to send the patches.

Essentially you need to properly describe what the patch does and how it impacts
the driver etc... Then there needs to be a valid 'Fixes' tag and stable list
should be CCed to backport to stable kernels.

- Mani

> Signed-off-by: tangchunyou <tangchunyou@....com>
> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 1c6043751dc9..2918b64708f9 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -234,6 +234,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  	if (!chip->reg_base)
>  		return -ENOMEM;
>  
> +	chip->reg_base += vsec_data.rg.off;
> +
>  	for (i = 0; i < chip->ll_wr_cnt; i++) {
>  		struct dw_edma_region *ll_region = &chip->ll_region_wr[i];
>  		struct dw_edma_region *dt_region = &chip->dt_region_wr[i];
> -- 
> 2.25.1
> 

-- 
மணிவண்ணன் சதாசிவம்