linux-kernel - Re: [PATCH net-next v04 1/3] af_packet: allow fanout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <670db98e775a5_2e174229479@willemb.c.googlers.com.notmuch>
Date: Mon, 14 Oct 2024 20:38:38 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Gur Stavi <gur.stavi@...wei.com>, 
 Gur Stavi <gur.stavi@...wei.com>
Cc: netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Shuah Khan <shuah@...nel.org>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v04 1/3] af_packet: allow fanout_add when socket
 is not RUNNING

Gur Stavi wrote:
> PACKET socket can retain its fanout membership through link down and up
> and leave a fanout while closed regardless of link state.
> However, socket was forbidden from joining a fanout while it was not
> RUNNING.
> 
> This patch allows PACKET socket to join fanout while not RUNNING.
> 
> Socket can be RUNNING if it has a specified protocol. Either directly
> from packet_create (being implicitly bound to any interface) or following
> a successful bind. Socket RUNNING state is switched off if it is bound to
> an interface that went down.
> 
> Instead of the test for RUNNING, this patch adds a test that socket can
> become RUNNING.
> 
> Signed-off-by: Gur Stavi <gur.stavi@...wei.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>