[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <u4afxqc3ludsic4n3hs3r3drg3ftmsbcwfjltic2mb66foo47x@xe57gltl77hq>
Date: Tue, 15 Oct 2024 07:59:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xianwei Zhao <xianwei.zhao@...ogic.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pinctrl: Add support for Amlogic A4
SoCs
On Mon, Oct 14, 2024 at 05:05:51PM +0800, Xianwei Zhao wrote:
> Add the new compatible name for Amlogic A4 pin controller, and add
> a new dt-binding header file which document the detail pin names.
>
> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>
> ---
...
> +++ b/include/dt-bindings/gpio/amlogic-a4-gpio.h
> @@ -0,0 +1,38 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
> + * Author: Xianwei Zhao <xianwei.zhao@...ogic.com>
> + */
> +
> +#ifndef _DT_BINDINGS_AMLOGIC_A4_GPIO_H
> +#define _DT_BINDINGS_AMLOGIC_A4_GPIO_H
> +
> +/* Standard port */
> +#define GPIOB_START 0
> +#define GPIOB_NUM 14
> +
> +#define GPIOD_START (GPIOB_START + GPIOB_NUM)
> +#define GPIOD_NUM 16
> +
> +#define GPIOE_START (GPIOD_START + GPIOD_NUM)
> +#define GPIOE_NUM 2
> +
> +#define GPIOT_START (GPIOE_START + GPIOE_NUM)
> +#define GPIOT_NUM 23
> +
> +#define GPIOX_START (GPIOT_START + GPIOT_NUM)
> +#define GPIOX_NUM 18
> +
> +#define PERIPHS_PIN_NUM (GPIOX_START + GPIOX_NUM)
> +
> +/* Aobus port */
> +#define GPIOAO_START 0
> +#define GPIOAO_NUM 7
> +
> +/* It's a special definition, put at the end, just 1 num */
> +#define GPIO_TEST_N (GPIOAO_START + GPIOAO_NUM)
> +#define AOBUS_PIN_NUM (GPIO_TEST_N + 1)
> +
> +#define AMLOGIC_GPIO(port, offset) (port##_START + (offset))
I do not think you implemented previous feedback. None of above are
bindings. Drop.
> +
> +#endif /* _DT_BINDINGS_AMLOGIC_A4_GPIO_H */
>
> --
> 2.37.1
>
Powered by blists - more mailing lists