[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241015-fast-smilodon-of-maturity-c983eb-mkl@pengutronix.de>
Date: Tue, 15 Oct 2024 08:21:28 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Ignat Korchagin <ignat@...udflare.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>, Oliver Hartkopp <socketcan@...tkopp.net>,
Alexander Aring <alex.aring@...il.com>, Stefan Schmidt <stefan@...enfreihafen.org>,
Miquel Raynal <miquel.raynal@...tlin.com>, David Ahern <dsahern@...nel.org>,
Willem de Bruijn <willemdebruijn.kernel@...il.com>, linux-bluetooth@...r.kernel.org, linux-can@...r.kernel.org,
linux-wpan@...r.kernel.org, kernel-team@...udflare.com, kuniyu@...zon.com,
alibuda@...ux.alibaba.com, Vincent Mailhol <mailhol.vincent@...adoo.fr>
Subject: Re: [PATCH net-next v3 4/9] net: af_can: do not leave a dangling sk
pointer in can_create()
On 14.10.2024 16:38:03, Ignat Korchagin wrote:
> On error can_create() frees the allocated sk object, but sock_init_data()
> has already attached it to the provided sock object. This will leave a
> dangling sk pointer in the sock object and may cause use-after-free later.
>
> Signed-off-by: Ignat Korchagin <ignat@...udflare.com>
> Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
Reviewed-by: Marc Kleine-Budde <mkl@...gutronix.de>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists