linux-kernel - Re: [PATCH v1 5/7] dt-bindings: pinctrl: samsung: add exynos990-wakeup-eint compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd97d92c-7999-4206-b8dd-7b79f9a84bcb@kernel.org>
Date: Tue, 15 Oct 2024 08:34:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Igor Belwon <igor.belwon@...tallysanemainliners.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-gpio@...r.kernel.org, david@...nlining.org
Subject: Re: [PATCH v1 5/7] dt-bindings: pinctrl: samsung: add
 exynos990-wakeup-eint compatible

On 15/10/2024 08:33, Krzysztof Kozlowski wrote:
> On 15/10/2024 08:27, Igor Belwon wrote:
>> Add a dedicated compatible for the exynos990-wakeup-eint node.
>>
>> Signed-off-by: Igor Belwon <igor.belwon@...tallysanemainliners.org>
>> ---
>>  .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml       | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> index 91516fedc872..cda5bf4cee4a 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> @@ -43,6 +43,7 @@ properties:
>>                - samsung,exynos7885-wakeup-eint
>>                - samsung,exynos850-wakeup-eint
>>                - samsung,exynos8895-wakeup-eint
> 
> There is no such line. You must document all dependencies and explain
> why. So far I don't see any reasons for external dependencies. This only
> will restrict the testing and make your patchset wait for very long...

I was wrong, 8895 was already merged.

Best regards,
Krzysztof