linux-kernel - Re: [PATCH 6.11 000/214] 6.11.4-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdb9391d-88ee-430c-8b3b-06b355f4087f@kernel.org>
Date: Tue, 15 Oct 2024 09:18:24 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Naresh Kamboju <naresh.kamboju@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: stable@...r.kernel.org, patches@...ts.linux.dev,
 linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
 akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
 patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
 jonathanh@...dia.com, f.fainelli@...il.com, sudipm.mukherjee@...il.com,
 srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
 allen.lkml@...il.com, broonie@...nel.org, Heiko Carstens
 <hca@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>,
 Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
 Thomas Richter <tmricht@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH 6.11 000/214] 6.11.4-rc1 review

On 15. 10. 24, 9:05, Naresh Kamboju wrote:
> On Mon, 14 Oct 2024 at 19:55, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>>
>> This is the start of the stable review cycle for the 6.11.4 release.
>> There are 214 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 16 Oct 2024 14:09:57 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>          https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.11.4-rc1.gz
>> or in the git tree and branch at:
>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.11.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
> 
> The S390 build broke on the stable-rc linux-6.11.y branch due to
> following build warnings / errors.
> 
> First seen on v6.11.3-215-ga491a66f8da4
>    GOOD: v6.11.3
>    BAD: v6.11.3-215-ga491a66f8da4
> 
> List of regressions,
> * s390, build
>    - clang-19-allnoconfig
>    - clang-19-defconfig
>    - clang-nightly-allnoconfig
>    - clang-nightly-defconfig
>    - gcc-13-allmodconfig
>    - gcc-13-allnoconfig
>    - gcc-13-defconfig
>    - gcc-13-tinyconfig
>    - gcc-8-allnoconfig
>    - gcc-8-defconfig-fe40093d
>    - gcc-8-tinyconfig
> 
> Build log:
> -------
>    arch/s390/include/asm/cpu_mf.h: Assembler messages:
>    arch/s390/include/asm/cpu_mf.h:165: Error: Unrecognized opcode: `lpp'
>    make[3]: *** [scripts/Makefile.build:244: arch/s390/boot/startup.o] Error 1
> 
>    arch/s390/include/asm/atomic_ops.h: Assembler messages:
>    arch/s390/include/asm/atomic_ops.h:83: Error: Unrecognized opcode: `laag'
>    arch/s390/include/asm/atomic_ops.h:83: Error: Unrecognized opcode: `laag'
>    make[3]: *** [scripts/Makefile.build:244: arch/s390/boot/vmem.o] Error 1
> 
>    arch/s390/include/asm/bitops.h: Assembler messages:
>    arch/s390/include/asm/bitops.h:308: Error: Unrecognized opcode: `flogr'
>    make[3]: *** [scripts/Makefile.build:244:
> arch/s390/boot/pgm_check_info.o] Error 1
> 
>    arch/s390/include/asm/timex.h: Assembler messages:
>    arch/s390/include/asm/timex.h:192: Error: Unrecognized opcode: `stckf'
>    arch/s390/include/asm/timex.h:192: Error: Unrecognized opcode: `stckf'
>    make[3]: *** [scripts/Makefile.build:244: arch/s390/boot/kaslr.o] Error 1
>    make[3]: Target 'arch/s390/boot/bzImage' not remade because of errors.
>    make[2]: *** [arch/s390/Makefile:137: bzImage] Error 2

The diff of cflags used for arch/s390/boot:
--- good        2024-10-15 09:13:59.769479783 +0200
+++ bad 2024-10-15 09:13:39.393060183 +0200
@@ -55,10 +55,10 @@
  -Wno
  -array
  -bounds
--march=z196
  -mtune=z13
  -Wa,
  -I/dev/shm/jslaby/linux/arch/s390/include
+-march=z900
  -I/dev/shm/jslaby/linux/arch/s390/boot
  -Iarch/s390/boot
  -DKBUILD_MODFILE='"arch/s390/boot/startup"'




Reverting of this makes it work again:
commit 51ab63c4cc8fbcfee58b8342a35006b45afbbd0d
Refs: v6.11.3-19-g51ab63c4cc8f
Author:     Heiko Carstens <hca@...ux.ibm.com>
AuthorDate: Wed Sep 4 11:39:27 2024 +0200
Commit:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CommitDate: Mon Oct 14 16:10:09 2024 +0200

     s390/boot: Compile all files with the same march flag

     [ Upstream commit fccb175bc89a0d37e3ff513bb6bf1f73b3a48950 ]


If the above is to be really used in stable (REASONS?), I believe at 
least these are missing:
ebcc369f1891 s390: Use MARCH_HAS_*_FEATURES defines
697b37371f4a s390: Provide MARCH_HAS_*_FEATURES defines


thanks,
-- 
js
suse labs