linux-kernel - Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56df7acd-100f-4402-9529-20e0bb825f07@quicinc.com>
Date: Tue, 15 Oct 2024 15:22:41 +0800
From: Yijie Yang <quic_yijiyang@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Vinod Koul <vkoul@...nel.org>, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        "Paolo
 Abeni" <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bhupesh
 Sharma <bhupesh.sharma@...aro.org>,
        Kishon Vijay Abraham I
	<kishon@...nel.org>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        <netdev@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <quic_tingweiz@...cinc.com>,
        <quic_aiquny@...cinc.com>
Subject: Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for
 qcs8300



On 2024-10-15 14:27, Krzysztof Kozlowski wrote:
> On 15/10/2024 08:21, Yijie Yang wrote:
>>
>>
>> On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
>>> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>>>> Add compatible for the MAC controller on qcs8300 platforms.
>>>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>>>> compatible.
>>>>
>>>> Signed-off-by: Yijie Yang <quic_yijiyang@...cinc.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> index 8cf29493b822..3ee5367bdde1 100644
>>>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> @@ -23,6 +23,10 @@ properties:
>>>>              - enum:
>>>>                  - qcom,qcs615-ethqos
>>>>              - const: qcom,sm8150-ethqos
>>>> +      - items:
>>>> +          - enum:
>>>> +              - qcom,qcs8300-ethqos
>>>> +          - const: qcom,sa8775p-ethqos
>>>
>>> This block should go before earlier qcs615, to keep order by fallback.
> 
> --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^
> 
> Here
> 
>>
>> Why this block should positioned before qcs615, given that it comes
>> later in alphabetical order?
> 
> sa < sm

Understood, thanks.

> 
> Best regards,
> Krzysztof
> 

-- 
Best Regards,
Yijie